You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2022/09/05 11:13:00 UTC
[shardingsphere] branch master updated: [Issue #20383]-Improved coverage for AlterSchemaStatementHandler (#20793)
This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 545e4943809 [Issue #20383]-Improved coverage for AlterSchemaStatementHandler (#20793)
545e4943809 is described below
commit 545e4943809f6e15b4c4c4ca3d1bba56de310b16
Author: Abhinav Koppula <ab...@gmail.com>
AuthorDate: Mon Sep 5 16:42:49 2022 +0530
[Issue #20383]-Improved coverage for AlterSchemaStatementHandler (#20793)
---
.../dialect/handler/ddl/AlterSchemaStatementHandlerTest.java | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterSchemaStatementHandlerTest.java b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterSchemaStatementHandlerTest.java
index f9c4b52e99d..55a36d65d84 100644
--- a/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterSchemaStatementHandlerTest.java
+++ b/shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/test/java/org/apache/shardingsphere/sql/parser/sql/dialect/handler/ddl/AlterSchemaStatementHandlerTest.java
@@ -20,18 +20,20 @@ package org.apache.shardingsphere.sql.parser.sql.dialect.handler.ddl;
import org.apache.shardingsphere.sql.parser.sql.common.value.identifier.IdentifierValue;
import org.apache.shardingsphere.sql.parser.sql.dialect.statement.opengauss.ddl.OpenGaussAlterSchemaStatement;
import org.apache.shardingsphere.sql.parser.sql.dialect.statement.postgresql.ddl.PostgreSQLAlterSchemaStatement;
+import org.apache.shardingsphere.sql.parser.sql.dialect.statement.sqlserver.ddl.SQLServerAlterSchemaStatement;
import org.junit.Test;
import java.util.Optional;
import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.assertTrue;
public final class AlterSchemaStatementHandlerTest {
@Test
- public void assertGetUsernameForPostgreSQL() {
+ public void assertGetRenameSchemaForPostgreSQL() {
PostgreSQLAlterSchemaStatement alterSchemaStatement = new PostgreSQLAlterSchemaStatement();
alterSchemaStatement.setRenameSchema(new IdentifierValue("new_schema"));
Optional<IdentifierValue> actual = AlterSchemaStatementHandler.getRenameSchema(alterSchemaStatement);
@@ -40,11 +42,17 @@ public final class AlterSchemaStatementHandlerTest {
}
@Test
- public void assertGetUsernameForOpenGauss() {
+ public void assertGetRenameSchemaForOpenGauss() {
OpenGaussAlterSchemaStatement alterSchemaStatement = new OpenGaussAlterSchemaStatement();
alterSchemaStatement.setRenameSchema(new IdentifierValue("new_schema"));
Optional<IdentifierValue> actual = AlterSchemaStatementHandler.getRenameSchema(alterSchemaStatement);
assertTrue(actual.isPresent());
assertThat(actual.get().getValue(), is("new_schema"));
}
+
+ @Test
+ public void assertGetRenameSchemaForSQLServer() {
+ SQLServerAlterSchemaStatement alterSchemaStatement = new SQLServerAlterSchemaStatement();
+ assertFalse(AlterSchemaStatementHandler.getRenameSchema(alterSchemaStatement).isPresent());
+ }
}