You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Niall Pemberton (JIRA)" <ji...@apache.org> on 2006/07/24 04:44:13 UTC
[jira] Created: (IO-87) Provide a convenience mehod in
FileFilterUtils to create a Size Range filter
Provide a convenience mehod in FileFilterUtils to create a Size Range filter
----------------------------------------------------------------------------
Key: IO-87
URL: http://issues.apache.org/jira/browse/IO-87
Project: Commons IO
Issue Type: New Feature
Components: Filters
Affects Versions: 1.2
Reporter: Niall Pemberton
Assigned To: Niall Pemberton
Priority: Minor
Fix For: 1.3
Provide a convenience mehod in FileFilterUtils to create a Size Range filter - by combining two SizeFileFilter's (one >= minimum and the other <= maximum) with an AndFileFilter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Resolved: (IO-87) Provide a convenience mehod in
FileFilterUtils to create a Size Range filter
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/IO-87?page=all ]
Niall Pemberton resolved IO-87.
-------------------------------
Resolution: Fixed
OK I've changed the parameter names as requested. Also renamed the method and made the javadoc clearer. Thanks for the feedback.
P.S. I don't think you're a dimwit - my impression of IO is that the quality is v.high and I put that down to the care and attention to detail people like youself have put into it :-)
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter
> ----------------------------------------------------------------------------
>
> Key: IO-87
> URL: http://issues.apache.org/jira/browse/IO-87
> Project: Commons IO
> Issue Type: New Feature
> Components: Filters
> Affects Versions: 1.2
> Reporter: Niall Pemberton
> Assigned To: Niall Pemberton
> Priority: Minor
> Fix For: 1.3
>
>
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter - by combining two SizeFileFilter's (one >= minimum and the other <= maximum) with an AndFileFilter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (IO-87) Provide a convenience mehod in
FileFilterUtils to create a Size Range filter
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/IO-87?page=comments#action_12423093 ]
Niall Pemberton commented on IO-87:
-----------------------------------
IMO minimumSize and maximumSize indicate that both are "inclusive" and therefore its unecessary to rename the parameters. I agree that the javadoc could be clearer in the method description and will fix that. Something like
/**
* Returns a filter that accepts files whose size is <= minimum size
* and >= maximum size.
*/
Currently this method implementation adds 1 to the maximumSize specified to achieve the <= maximum - but I've just opened a bug (IO-89) relating to the inconsistency in SizeFileFilter (and AgeFileFilter) which it would be good to resolve before fixing this.
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter
> ----------------------------------------------------------------------------
>
> Key: IO-87
> URL: http://issues.apache.org/jira/browse/IO-87
> Project: Commons IO
> Issue Type: New Feature
> Components: Filters
> Affects Versions: 1.2
> Reporter: Niall Pemberton
> Assigned To: Niall Pemberton
> Priority: Minor
> Fix For: 1.3
>
>
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter - by combining two SizeFileFilter's (one >= minimum and the other <= maximum) with an AndFileFilter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (IO-87) Provide a convenience mehod in
FileFilterUtils to create a Size Range filter
Posted by "Stephen Colebourne (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/IO-87?page=comments#action_12423208 ]
Stephen Colebourne commented on IO-87:
--------------------------------------
Feel free to tink of me as a dimwit, but minSize and maxSize don't always mean inclusive in my brain. hats why I always like to spell it out very explicitly.
I use the parameter names to do this, as then IDE autocompletes pick it up rapidly. I guess its just a coding standard I've got into, and it certainy doesnt harm.
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter
> ----------------------------------------------------------------------------
>
> Key: IO-87
> URL: http://issues.apache.org/jira/browse/IO-87
> Project: Commons IO
> Issue Type: New Feature
> Components: Filters
> Affects Versions: 1.2
> Reporter: Niall Pemberton
> Assigned To: Niall Pemberton
> Priority: Minor
> Fix For: 1.3
>
>
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter - by combining two SizeFileFilter's (one >= minimum and the other <= maximum) with an AndFileFilter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (IO-87) Provide a convenience mehod in
FileFilterUtils to create a Size Range filter
Posted by "Stephen Colebourne (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/IO-87?page=comments#action_12423008 ]
Stephen Colebourne commented on IO-87:
--------------------------------------
The parameters need to specify whether they are inclusive or exclusive, for example
@param minSizeInclusive
@param maxSizeExclusive
This then needs adding to release notes, and the call closing.
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter
> ----------------------------------------------------------------------------
>
> Key: IO-87
> URL: http://issues.apache.org/jira/browse/IO-87
> Project: Commons IO
> Issue Type: New Feature
> Components: Filters
> Affects Versions: 1.2
> Reporter: Niall Pemberton
> Assigned To: Niall Pemberton
> Priority: Minor
> Fix For: 1.3
>
>
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter - by combining two SizeFileFilter's (one >= minimum and the other <= maximum) with an AndFileFilter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (IO-87) Provide a convenience mehod in
FileFilterUtils to create a Size Range filter
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/IO-87?page=comments#action_12422955 ]
Niall Pemberton commented on IO-87:
-----------------------------------
I've committed this since its a minor change, but will leave the issue open for comments.
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter
> ----------------------------------------------------------------------------
>
> Key: IO-87
> URL: http://issues.apache.org/jira/browse/IO-87
> Project: Commons IO
> Issue Type: New Feature
> Components: Filters
> Affects Versions: 1.2
> Reporter: Niall Pemberton
> Assigned To: Niall Pemberton
> Priority: Minor
> Fix For: 1.3
>
>
> Provide a convenience mehod in FileFilterUtils to create a Size Range filter - by combining two SizeFileFilter's (one >= minimum and the other <= maximum) with an AndFileFilter
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org