[GitHub] [iceberg] szehon-ho commented on a change in pull request #2804: [Issue-2741] use RetryingMetaStoreClient

[GitBox <gi...@apache.org>]

szehon-ho commented on a change in pull request #2804:
URL: https://github.com/apache/iceberg/pull/2804#discussion_r703813734



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -47,10 +42,10 @@ public HiveClientPool(int poolSize, Configuration conf) {
   }
 
   @Override
-  protected HiveMetaStoreClient newClient()  {
+  protected IMetaStoreClient newClient()  {
     try {
       try {
-        return CLIENT_CTOR.newInstance(hiveConf);
+        return RetryingMetaStoreClient.getProxy(hiveConf, null, HiveMetaStoreClient.class.getName());

Review comment:
       Maybe I'm mistaken, but this is the CTOR that is @VisibleForTesting?
   
   Can we use: 
   
   ``` 
   public static IMetaStoreClient getProxy(
         Configuration hiveConf, boolean allowEmbedded)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org