You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2024/01/05 11:54:49 UTC
[PR] [#1407] feat(rust): refactor localfile store to speed up writing [incubator-uniffle]
zuston opened a new pull request, #1422:
URL: https://github.com/apache/incubator-uniffle/pull/1422
### What changes were proposed in this pull request?
1. using `opendal` crate to simplify read/write
2. avoid using dashmap.get to fix potential deadlock
### Why are the changes needed?
For: #1407
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1407] feat(rust): refactor localfile store to speed up writing [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1422:
URL: https://github.com/apache/incubator-uniffle/pull/1422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1407] feat(rust): refactor localfile store to speed up writing [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1422:
URL: https://github.com/apache/incubator-uniffle/pull/1422#issuecomment-1878562716
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`602611c`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/602611cc1adff995ab23b5e3776b1600f258d095?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.23% compared to head [(`2d48f3e`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.58%.
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1422 +/- ##
============================================
+ Coverage 53.23% 53.58% +0.34%
+ Complexity 2721 2192 -529
============================================
Files 419 342 -77
Lines 23982 15401 -8581
Branches 2045 1419 -626
============================================
- Hits 12768 8253 -4515
+ Misses 10427 6687 -3740
+ Partials 787 461 -326
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org