You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/25 23:50:47 UTC
[GitHub] [iceberg] kbendick opened a new pull request #4235: Core - RESTCatalog and an initial HttpRESTClient (impl of RESTClient)
kbendick opened a new pull request #4235:
URL: https://github.com/apache/iceberg/pull/4235
This adds a basic RESTCatalog, which can initialize itself using the `RESTCatalogConfigResponse`, according to the specification.
It performs a one time connection to the passed in `uri`, then destroys that connection and configures itself using the configuration pulled from the server as merged with the client provided config.
It also adds some utility functions for encoding / decoding a namespace from a path variable. I'm still hoping to find a better way to do this that is more opaque to the caller (so that they don't have to decode on the server side), but for now this is something.
This is to unblock concurrent work on a catalog test harness, as well as setting up the basic layout of the rest catalog.
More tests and implementation will be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4235: Core - RESTCatalog and an initial HttpRESTClient (impl of RESTClient)
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4235:
URL: https://github.com/apache/iceberg/pull/4235#discussion_r815235608
##########
File path: core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java
##########
@@ -48,6 +50,8 @@ private RESTSerializers() {
public static void registerAll(ObjectMapper mapper) {
SimpleModule module = new SimpleModule();
module
+ .addSerializer(ErrorResponse.class, new ErrorResponseSerializer())
+ .addDeserializer(ErrorResponse.class, new ErrorResponseDeserializer())
Review comment:
Moved all of this to its own PR: https://github.com/apache/iceberg/pull/4236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org