You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/13 11:04:00 UTC

[jira] [Commented] (METRON-1037) Stellar power function

    [ https://issues.apache.org/jira/browse/METRON-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085538#comment-16085538 ] 

ASF GitHub Bot commented on METRON-1037:
----------------------------------------

GitHub user simonellistonball opened a pull request:

    https://github.com/apache/metron/pull/651

    METRON-1037 Added POWER function

    ## Contributor Comments
    
    This is a quick addition to the Math functions. It may be worth revising following the work @cestella did this morning to add a more general implementation on top of #650 
    
    I will probably add 2 argument capabilities and port this work to #650 when it's in once that is in.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/simonellistonball/incubator-metron METRON-1037

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #651
    
----
commit 3e784245576d28ba275b1d4b3cf98347ea13f14f
Author: Simon Elliston Ball <si...@simonellistonball.com>
Date:   2017-07-13T00:51:44Z

    Added POWER function

----


> Stellar power function
> ----------------------
>
>                 Key: METRON-1037
>                 URL: https://issues.apache.org/jira/browse/METRON-1037
>             Project: Metron
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Simon Elliston Ball
>
> Stellar does not currently have a power function. We should have a function of the form POWER(number,power) named for consistency with SQL and Excel. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)