You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/11/06 02:28:44 UTC
[jira] Created: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
BlocksMap and BlockInfo should be package private.
--------------------------------------------------
Key: HADOOP-4599
URL: https://issues.apache.org/jira/browse/HADOOP-4599
Project: Hadoop Core
Issue Type: Improvement
Affects Versions: 0.19.0
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 0.20.0
BlocksMap and BlockInfo should be changed from public to package private.
This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645995#action_12645995 ]
Hudson commented on HADOOP-4599:
--------------------------------
Integrated in Hadoop-trunk #655 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/655/])
. BlocksMap and BlockInfo made package private. Contributed by Konstantin Shvachko.
> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
> Key: HADOOP-4599
> URL: https://issues.apache.org/jira/browse/HADOOP-4599
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4599:
----------------------------------------
Attachment: PkgRpivateBlocksMap.patch
> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
> Key: HADOOP-4599
> URL: https://issues.apache.org/jira/browse/HADOOP-4599
> Project: Hadoop Core
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4599:
----------------------------------------
Status: Patch Available (was: Open)
> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
> Key: HADOOP-4599
> URL: https://issues.apache.org/jira/browse/HADOOP-4599
> Project: Hadoop Core
> Issue Type: Improvement
> Affects Versions: 0.19.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645853#action_12645853 ]
Konstantin Shvachko commented on HADOOP-4599:
---------------------------------------------
TestBalancer timed out. This is not related to the changes.
> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
> Key: HADOOP-4599
> URL: https://issues.apache.org/jira/browse/HADOOP-4599
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4599:
----------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
> Key: HADOOP-4599
> URL: https://issues.apache.org/jira/browse/HADOOP-4599
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4599:
-------------------------------------------
Component/s: dfs
Hadoop Flags: [Reviewed]
+1
> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
> Key: HADOOP-4599
> URL: https://issues.apache.org/jira/browse/HADOOP-4599
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4599) BlocksMap and BlockInfo should be
package private.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645717#action_12645717 ]
Hadoop QA commented on HADOOP-4599:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12393417/PkgRpivateBlocksMap.patch
against trunk revision 712033.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3546/console
This message is automatically generated.
> BlocksMap and BlockInfo should be package private.
> --------------------------------------------------
>
> Key: HADOOP-4599
> URL: https://issues.apache.org/jira/browse/HADOOP-4599
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.20.0
>
> Attachments: PkgRpivateBlocksMap.patch
>
>
> BlocksMap and BlockInfo should be changed from public to package private.
> This is possible now since HADOOP-4572 moved the test class CreateEditsLog under the namenode package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.