You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Justin Edelson <ju...@gmail.com> on 2010/02/12 15:15:35 UTC
Re: Proposal to release jcr bundles before moving to JR2, was Re: svn
commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base:
AbstractSlingRepository.java SessionProxyHandler.java
On Feb 12, 2010, at 8:51 AM, Ian Boston <ie...@tfd.co.uk> wrote:
>
> On 12 Feb 2010, at 13:37, Carsten Ziegeler wrote:
>
>> Ian Boston wrote:
>>> eg
>>> testModifyAceForUser
>>> (org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest)
>>> Time elapsed: 0.151 sec <<< FAILURE!
>>> junit.framework.AssertionFailedError: expected:<200> but was:<500>
>>>
>>> I cant find any matching exception in the error log at the moment.
>> Yepp, I couldn't find it either :(
>>
>> Can you please try to remove the if statement around the
>> workInterfaces.add(...) inside the addInterfaces method in the
>> SessionProxyHandler?
>
>
> Will do,
> Jut put it through the debuger and the reflection in
> AccessControlUtil is finding that there is no method
> getAccessControlManager on the session, because thats part of
> JackrabbitSession not Session (I guess).
Yeah, but that should be a proxied interface. I'll watch for your
commit.
Justin
>
> Ian
>
>>
>> Regards
>> Carsten
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>
Re: Proposal to release jcr bundles before moving to JR2, was Re:
svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base:
AbstractSlingRepository.java SessionProxyHandler.java
Posted by Justin Edelson <ju...@gmail.com>.
On 2/12/10 10:33 AM, Ian Boston wrote:
> Sorry for the delay, everything ok here, good to go.
> Ian
I'm having some trouble getting an integration test which validates that
Sling-Namespaces works with impersonation, so please hold on the release
for a bit.
Thanks,
Justin
>
> On 12 Feb 2010, at 15:02, Ian Boston wrote:
>
>> I am just running through a second set of external integration tests, should be done in a few minutes.
>> Ian
>>
>> On 12 Feb 2010, at 14:59, Carsten Ziegeler wrote:
>>
>>> With latest trunk I don't get any integration test errors anymore.
>>>
>>> Carsten
>>> --
>>> Carsten Ziegeler
>>> cziegeler@apache.org
>>
>
Re: Proposal to release jcr bundles before moving to JR2, was Re: svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base: AbstractSlingRepository.java SessionProxyHandler.java
Posted by Ian Boston <ie...@tfd.co.uk>.
Sorry for the delay, everything ok here, good to go.
Ian
On 12 Feb 2010, at 15:02, Ian Boston wrote:
> I am just running through a second set of external integration tests, should be done in a few minutes.
> Ian
>
> On 12 Feb 2010, at 14:59, Carsten Ziegeler wrote:
>
>> With latest trunk I don't get any integration test errors anymore.
>>
>> Carsten
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>
Re: Proposal to release jcr bundles before moving to JR2, was Re: svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base: AbstractSlingRepository.java SessionProxyHandler.java
Posted by Ian Boston <ie...@tfd.co.uk>.
I am just running through a second set of external integration tests, should be done in a few minutes.
Ian
On 12 Feb 2010, at 14:59, Carsten Ziegeler wrote:
> With latest trunk I don't get any integration test errors anymore.
>
> Carsten
> --
> Carsten Ziegeler
> cziegeler@apache.org
Re: Proposal to release jcr bundles before moving to JR2, was Re:
svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base:
AbstractSlingRepository.java SessionProxyHandler.java
Posted by Carsten Ziegeler <cz...@apache.org>.
With latest trunk I don't get any integration test errors anymore.
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: Proposal to release jcr bundles before moving to JR2, was Re:
svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base:
AbstractSlingRepository.java SessionProxyHandler.java
Posted by Justin Edelson <ju...@gmail.com>.
On 2/12/10 9:52 AM, Ian Boston wrote:
>
> On 12 Feb 2010, at 14:47, Justin Edelson wrote:
>
>> On 2/12/10 9:43 AM, Ian Boston wrote:
>>>> Yeah, but that should be a proxied interface. I'll watch for your
>>>> commit.
>>>
>>> Just pushed a commit, but I notice from your comments on code review that there may be further problems with the reverts I did to jcr.api
>>>
>>
>> It's not a big problem, just an unnecessary removal. Just to be clear,
>> jcr.api does NOT need to be released.
>>
>> I'm going to reapply the integration test for the Sling-Namespaces
>> header. This is good to have to ensure that SLING-1366 stays fixed.
>
> Ok,
> I was just intending to revert 909431 when this was all done which would put head back into position ? Can do either, upto you.
I'd like to have the NamespaceMapper in jcr.api in trunk so I can use
it. I'll apply the rest of the (re-)revert to my JR2 branch and I can
apply it from there once the releases are done.
Justin
> Ian
>
>
>>
>> Justin
>>
>>> Ian
>>>
>>>
>>>>
>>>> Justin
>>>>>
>>>>> Ian
>>>>>
>>>>>>
>>>>>> Regards
>>>>>> Carsten
>>>>>> --
>>>>>> Carsten Ziegeler
>>>>>> cziegeler@apache.org
>>>>>
>>>
>>
>
Re: Proposal to release jcr bundles before moving to JR2, was Re: svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base: AbstractSlingRepository.java SessionProxyHandler.java
Posted by Ian Boston <ie...@tfd.co.uk>.
On 12 Feb 2010, at 14:47, Justin Edelson wrote:
> On 2/12/10 9:43 AM, Ian Boston wrote:
>>> Yeah, but that should be a proxied interface. I'll watch for your
>>> commit.
>>
>> Just pushed a commit, but I notice from your comments on code review that there may be further problems with the reverts I did to jcr.api
>>
>
> It's not a big problem, just an unnecessary removal. Just to be clear,
> jcr.api does NOT need to be released.
>
> I'm going to reapply the integration test for the Sling-Namespaces
> header. This is good to have to ensure that SLING-1366 stays fixed.
Ok,
I was just intending to revert 909431 when this was all done which would put head back into position ? Can do either, upto you.
Ian
>
> Justin
>
>> Ian
>>
>>
>>>
>>> Justin
>>>>
>>>> Ian
>>>>
>>>>>
>>>>> Regards
>>>>> Carsten
>>>>> --
>>>>> Carsten Ziegeler
>>>>> cziegeler@apache.org
>>>>
>>
>
Re: Proposal to release jcr bundles before moving to JR2, was Re:
svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base:
AbstractSlingRepository.java SessionProxyHandler.java
Posted by Justin Edelson <ju...@gmail.com>.
On 2/12/10 9:43 AM, Ian Boston wrote:
>> Yeah, but that should be a proxied interface. I'll watch for your
>> commit.
>
> Just pushed a commit, but I notice from your comments on code review that there may be further problems with the reverts I did to jcr.api
>
It's not a big problem, just an unnecessary removal. Just to be clear,
jcr.api does NOT need to be released.
I'm going to reapply the integration test for the Sling-Namespaces
header. This is good to have to ensure that SLING-1366 stays fixed.
Justin
> Ian
>
>
>>
>> Justin
>>>
>>> Ian
>>>
>>>>
>>>> Regards
>>>> Carsten
>>>> --
>>>> Carsten Ziegeler
>>>> cziegeler@apache.org
>>>
>
Re: Proposal to release jcr bundles before moving to JR2, was Re: svn commit: r908956 - in /sling/trunk/bundles/jcr/base/src/main/java/org/apache/sling/jcr/base: AbstractSlingRepository.java SessionProxyHandler.java
Posted by Ian Boston <ie...@tfd.co.uk>.
On 12 Feb 2010, at 14:15, Justin Edelson wrote:
> On Feb 12, 2010, at 8:51 AM, Ian Boston <ie...@tfd.co.uk> wrote:
>
>>
>> On 12 Feb 2010, at 13:37, Carsten Ziegeler wrote:
>>
>>> Ian Boston wrote:
>>>> eg
>>>> testModifyAceForUser
>>>> (org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest)
>>>> Time elapsed: 0.151 sec <<< FAILURE!
>>>> junit.framework.AssertionFailedError: expected:<200> but was:<500>
>>>>
>>>> I cant find any matching exception in the error log at the moment.
>>> Yepp, I couldn't find it either :(
>>>
>>> Can you please try to remove the if statement around the
>>> workInterfaces.add(...) inside the addInterfaces method in the
>>> SessionProxyHandler?
>>
>>
>> Will do,
>> Jut put it through the debuger and the reflection in
>> AccessControlUtil is finding that there is no method
>> getAccessControlManager on the session, because thats part of
>> JackrabbitSession not Session (I guess).
>
> Yeah, but that should be a proxied interface. I'll watch for your
> commit.
Just pushed a commit, but I notice from your comments on code review that there may be further problems with the reverts I did to jcr.api
Ian
>
> Justin
>>
>> Ian
>>
>>>
>>> Regards
>>> Carsten
>>> --
>>> Carsten Ziegeler
>>> cziegeler@apache.org
>>