You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ChengXiangLi <gi...@git.apache.org> on 2015/09/24 05:19:09 UTC
[GitHub] flink pull request: [FLINK-2754] FixedLengthRecordSorter can not w...
GitHub user ChengXiangLi opened a pull request:
https://github.com/apache/flink/pull/1178
[FLINK-2754] FixedLengthRecordSorter can not write to output cross MemorySegments.
The issue happens while call FixedLengthRecordSorter::WriteToOutput with non-zero offset and write record across multi memory pages. Fix the issue and add more unit test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChengXiangLi/flink flink-2754
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1178
----
commit ce2aae5a41f419104511ca8372bb8e7f2f41a1c2
Author: chengxiang li <ch...@intel.com>
Date: 2015-09-24T03:20:10Z
[FLINK-2754] Fixed FixedLengthRecordSorter write to multi memory pages issue and add more unit tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2754] FixedLengthRecordSorter can not w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2754] FixedLengthRecordSorter can not w...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1178#issuecomment-144015272
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2754] FixedLengthRecordSorter can not w...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1178#issuecomment-142947995
Looks good to me!
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---