You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2008/04/26 17:27:47 UTC
Need help diagnosing a crash (Re: svn commit: r30798 - in
branches/dont-save-plaintext-passwords-by-default: .
subversion/libsvn_subr)
On Sat, Apr 26, 2008 at 10:18:01AM -0700, stsp@tigris.org wrote:
> Author: stsp
> Date: Sat Apr 26 10:18:01 2008
> New Revision: 30798
>
Does anyone have an idea what the source of the crash shown
below could be? I mean, is this something that is likely to
have some known cause or will I have to dig really deep to
find this bug?
This is the diff which added the user answer caching.
These changes are likely what made this bug visible:
svn diff -c30793 \
https://svn.collab.net/repos/svn/branches/dont-save-plaintext-passwords-by-default
Thanks.
> --- branches/dont-save-plaintext-passwords-by-default/TODO.branch Sat Apr 26 08:43:01 2008 (r30797)
> +++ branches/dont-save-plaintext-passwords-by-default/TODO.branch Sat Apr 26 10:18:01 2008 (r30798)
> @@ -1,5 +1,75 @@
> TODOS in this branch:
>
> +- Fix the following crash, no idea why this is happening yet.
> + Apparently the pool we're caching in is not persistent.
> +
> + (gdb) rm -rf /tmp/svncfg
> + (gdb) br svn_cmdline_auth_plaintext_prompt
> + Breakpoint 1 at 0x814b527: file subversion/libsvn_subr/prompt.c, line 386.
> + (gdb) run --config-dir /tmp/svncfg ls svn://localhost svn://localhost
> + Starting program: /home/stsp/elego/prefix/svn-dont-save-plaintext-passwords-by-default-prefix/bin/svn --config-dir /tmp/svncfg ls svn://localhost svn://localhost
> + [New LWP 100152]
> + [New Thread 0x28801100 (LWP 100152)]
> + Authentication realm: <svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1
> + Password for 'stsp':
> + Authentication realm: <svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1
> + Username: harry
> + Password for 'harry':
> + [Switching to Thread 0x28801100 (LWP 100152)]
> +
> + Breakpoint 1, svn_cmdline_auth_plaintext_prompt (
> + may_save_plaintext=0xbfbfda68,
> + realmstring=0x2885cde0 "<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1", baton=0x2883bba8, pool=0x2885a018)
> + at subversion/libsvn_subr/prompt.c:386
> + 386 const char *answer = NULL;
> + (gdb) c
> + Continuing.
> + ATTENTION! Your password for authentication realm
> + '<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1'
> + can only be stored to disk unencrypted! It is recommended to configure
> + your system so that Subversion can store passwords encrypted, if possible.
> + See the documentation for details. You can get rid of this warning by
> + editing '/tmp/svncfg/servers'
> + and setting 'store-plaintext-passwords' to either 'yes' or 'no'.
> + -----------------------------------------------------------------------
> + Store password unencrypted (yes/no)? yes
> +
> + Breakpoint 1, svn_cmdline_auth_plaintext_prompt (
> + may_save_plaintext=0xbfbfda68,
> + realmstring=0x28859de0 "<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1", baton=0x2883bba8, pool=0x28857018)
> + at subversion/libsvn_subr/prompt.c:386
> + 386 const char *answer = NULL;
> + (gdb) c
> + Continuing.
> +
> +
> + Note: Should have gotten answer from cache here, but it's 0x0.
> +
> +
> + -----------------------------------------------------------------------
> + ATTENTION! Your password for authentication realm
> + '<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1'
> + can only be stored to disk unencrypted! It is recommended to configure
> + your system so that Subversion can store passwords encrypted, if possible.
> + See the documentation for details. You can get rid of this warning by
> + editing '/tmp/svncfg/servers'
> + and setting 'store-plaintext-passwords' to either 'yes' or 'no'.
> + -----------------------------------------------------------------------
> + Store password unencrypted (yes/no)? yes
> +
> + Program received signal SIGSEGV, Segmentation fault.
> + apr_palloc (pool=0x2885a018, size=24) at memory/unix/apr_pools.c:633
> + 633 if (size < (apr_size_t)(active->endp - active->first_avail)) {
> + (gdb) p *pool
> + $1 = {parent = 0x2d2d2d2d, child = 0x2d2d2d2d, sibling = 0x2d2d2d2d,
> + ref = 0x2d2d2d2d, cleanups = 0x2d2d2d2d, free_cleanups = 0x2d2d2d2d,
> + allocator = 0x2d2d2d2d, subprocesses = 0x2d2d2d2d, abort_fn = 0x2d2d2d2d,
> + user_data = 0x2d2d2d2d,
> + tag = 0x2d2d2d2d <Error reading address 0x2d2d2d2d: Bad address>,
> + active = 0x2d2d2d2d, self = 0x2d2d2d2d,
> + self_first_avail = 0x2d2d2d2d <Error reading address 0x2d2d2d2d: Bad address>}
> + (gdb)
> +
--
Stefan Sperling <st...@elego.de> Software Monkey
German law requires the following banner :(
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de CEO: Olaf Wagner
Store password unencrypted (yes/no)? No
Re: Need help diagnosing a crash (Re: svn commit: r30798 - in
branches/dont-save-plaintext-passwords-by-default: .
subversion/libsvn_subr)
Posted by Stefan Sperling <st...@elego.de>.
On Mon, Apr 28, 2008 at 03:49:38PM -0700, David Glasser wrote:
> Is this still happening?
>
> --dave
Nope, this was the pool lifetime issue fixed in r30800.
Thanks,
--
Stefan Sperling <st...@elego.de> Software Monkey
German law requires the following banner :(
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de CEO: Olaf Wagner
Store password unencrypted (yes/no)? No
Re: Need help diagnosing a crash (Re: svn commit: r30798 - in branches/dont-save-plaintext-passwords-by-default: . subversion/libsvn_subr)
Posted by David Glasser <gl...@davidglasser.net>.
Is this still happening?
--dave
On Sat, Apr 26, 2008 at 10:27 AM, Stefan Sperling <st...@elego.de> wrote:
> On Sat, Apr 26, 2008 at 10:18:01AM -0700, stsp@tigris.org wrote:
> > Author: stsp
> > Date: Sat Apr 26 10:18:01 2008
> > New Revision: 30798
> >
>
> Does anyone have an idea what the source of the crash shown
> below could be? I mean, is this something that is likely to
> have some known cause or will I have to dig really deep to
> find this bug?
>
> This is the diff which added the user answer caching.
> These changes are likely what made this bug visible:
>
> svn diff -c30793 \
> https://svn.collab.net/repos/svn/branches/dont-save-plaintext-passwords-by-default
>
> Thanks.
>
> > --- branches/dont-save-plaintext-passwords-by-default/TODO.branch Sat Apr 26 08:43:01 2008 (r30797)
> > +++ branches/dont-save-plaintext-passwords-by-default/TODO.branch Sat Apr 26 10:18:01 2008 (r30798)
> > @@ -1,5 +1,75 @@
> > TODOS in this branch:
> >
> > +- Fix the following crash, no idea why this is happening yet.
> > + Apparently the pool we're caching in is not persistent.
> > +
> > + (gdb) rm -rf /tmp/svncfg
> > + (gdb) br svn_cmdline_auth_plaintext_prompt
> > + Breakpoint 1 at 0x814b527: file subversion/libsvn_subr/prompt.c, line 386.
> > + (gdb) run --config-dir /tmp/svncfg ls svn://localhost svn://localhost
> > + Starting program: /home/stsp/elego/prefix/svn-dont-save-plaintext-passwords-by-default-prefix/bin/svn --config-dir /tmp/svncfg ls svn://localhost svn://localhost
> > + [New LWP 100152]
> > + [New Thread 0x28801100 (LWP 100152)]
> > + Authentication realm: <svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1
> > + Password for 'stsp':
> > + Authentication realm: <svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1
> > + Username: harry
> > + Password for 'harry':
> > + [Switching to Thread 0x28801100 (LWP 100152)]
> > +
> > + Breakpoint 1, svn_cmdline_auth_plaintext_prompt (
> > + may_save_plaintext=0xbfbfda68,
> > + realmstring=0x2885cde0 "<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1", baton=0x2883bba8, pool=0x2885a018)
> > + at subversion/libsvn_subr/prompt.c:386
> > + 386 const char *answer = NULL;
> > + (gdb) c
> > + Continuing.
> > + ATTENTION! Your password for authentication realm
> > + '<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1'
> > + can only be stored to disk unencrypted! It is recommended to configure
> > + your system so that Subversion can store passwords encrypted, if possible.
> > + See the documentation for details. You can get rid of this warning by
> > + editing '/tmp/svncfg/servers'
> > + and setting 'store-plaintext-passwords' to either 'yes' or 'no'.
> > + -----------------------------------------------------------------------
> > + Store password unencrypted (yes/no)? yes
> > +
> > + Breakpoint 1, svn_cmdline_auth_plaintext_prompt (
> > + may_save_plaintext=0xbfbfda68,
> > + realmstring=0x28859de0 "<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1", baton=0x2883bba8, pool=0x28857018)
> > + at subversion/libsvn_subr/prompt.c:386
> > + 386 const char *answer = NULL;
> > + (gdb) c
> > + Continuing.
> > +
> > +
> > + Note: Should have gotten answer from cache here, but it's 0x0.
> > +
> > +
> > + -----------------------------------------------------------------------
> > + ATTENTION! Your password for authentication realm
> > + '<svn://localhost:3690> f2d6a8f5-8913-dd11-8d00-000b6ad51eb1'
> > + can only be stored to disk unencrypted! It is recommended to configure
> > + your system so that Subversion can store passwords encrypted, if possible.
> > + See the documentation for details. You can get rid of this warning by
> > + editing '/tmp/svncfg/servers'
> > + and setting 'store-plaintext-passwords' to either 'yes' or 'no'.
> > + -----------------------------------------------------------------------
> > + Store password unencrypted (yes/no)? yes
> > +
> > + Program received signal SIGSEGV, Segmentation fault.
> > + apr_palloc (pool=0x2885a018, size=24) at memory/unix/apr_pools.c:633
> > + 633 if (size < (apr_size_t)(active->endp - active->first_avail)) {
> > + (gdb) p *pool
> > + $1 = {parent = 0x2d2d2d2d, child = 0x2d2d2d2d, sibling = 0x2d2d2d2d,
> > + ref = 0x2d2d2d2d, cleanups = 0x2d2d2d2d, free_cleanups = 0x2d2d2d2d,
> > + allocator = 0x2d2d2d2d, subprocesses = 0x2d2d2d2d, abort_fn = 0x2d2d2d2d,
> > + user_data = 0x2d2d2d2d,
> > + tag = 0x2d2d2d2d <Error reading address 0x2d2d2d2d: Bad address>,
> > + active = 0x2d2d2d2d, self = 0x2d2d2d2d,
> > + self_first_avail = 0x2d2d2d2d <Error reading address 0x2d2d2d2d: Bad address>}
> > + (gdb)
> > +
>
> --
> Stefan Sperling <st...@elego.de> Software Monkey
>
> German law requires the following banner :(
> elego Software Solutions GmbH HRB 77719
> Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
> 13355 Berlin Fax: +49 30 23 45 86 95
> http://www.elego.de CEO: Olaf Wagner
>
> Store password unencrypted (yes/no)? No
>
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org