You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/07/19 20:43:15 UTC
Review Request 67976: Windows: Added `nullptr` checks when using
`libwinio_loop` pointer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67976/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
Bugs: MESOS-9097
https://issues.apache.org/jira/browse/MESOS-9097
Repository: mesos
Description
-------
It was discovered that the `Socket` constructor could dereference a
null pointer (by way of `prepare_async()`) if the Windows IOCP event
loop had not yet been initialized. So now we check for its
initialization before each dereference, and return an error or fatal
log event.
In order to ensure that it is initialized in `test-linkee`, we call
`process::initialize()`. This should be fixed in the future, per
MESOS-9097.
Diffs
-----
3rdparty/libprocess/src/tests/test_linkee.cpp cc482717290f72a5fd95fe745ac01893c0ce41f8
3rdparty/libprocess/src/windows/event_loop.cpp 0050ff0d87fdd01bf37742233fcd38b02f284ff3
3rdparty/libprocess/src/windows/io.cpp 1f9adde36192b673d7051549295a0f403be8e718
Diff: https://reviews.apache.org/r/67976/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 67976: Windows: Added `nullptr` checks when using
`libwinio_loop` pointer.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67976/#review206353
-----------------------------------------------------------
Ship it!
Ship It!
- John Kordich
On July 19, 2018, 8:43 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67976/
> -----------------------------------------------------------
>
> (Updated July 19, 2018, 8:43 p.m.)
>
>
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, Liangyu Zhao, and Radhika Jandhyala.
>
>
> Bugs: MESOS-9097
> https://issues.apache.org/jira/browse/MESOS-9097
>
>
> Repository: mesos
>
>
> Description
> -------
>
> It was discovered that the `Socket` constructor could dereference a
> null pointer (by way of `prepare_async()`) if the Windows IOCP event
> loop had not yet been initialized. So now we check for its
> initialization before each dereference, and return an error or fatal
> log event.
>
> In order to ensure that it is initialized in `test-linkee`, we call
> `process::initialize()`. This should be fixed in the future, per
> MESOS-9097.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/test_linkee.cpp cc482717290f72a5fd95fe745ac01893c0ce41f8
> 3rdparty/libprocess/src/windows/event_loop.cpp 0050ff0d87fdd01bf37742233fcd38b02f284ff3
> 3rdparty/libprocess/src/windows/io.cpp 1f9adde36192b673d7051549295a0f403be8e718
>
>
> Diff: https://reviews.apache.org/r/67976/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>