You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "smolnar82 (via GitHub)" <gi...@apache.org> on 2023/10/18 11:52:39 UTC
[PR] KNOX-2969 - KnoxSSO Cookies should be ignored while calculating token limit per user [knox]
smolnar82 opened a new pull request, #805:
URL: https://github.com/apache/knox/pull/805
## What changes were proposed in this pull request?
Modified the logic used for calculating the token limit per user in a way such that it ignores the previously generated KnoxSSO cookies. That is, a user can have as many KnoxSSO cookies as they want, but regular tokens are still limited.
## How was this patch tested?
Updated JUnit tests and executed manual testing:
1. Kept the default token limit per user = 10
2. I had three different sessions in different browsers as the `admin` user
3. Disabled one session
4. In one of the remaining sessions generated 10 tokens successfully (please note even the 8th, 9th, and 10th tokens were generated despite the fact I already had 3 KnoxSSO tokens for the same user)
5. The 11th token generation failed as expected
<img width="1779" alt="Screenshot 2023-10-18 at 13 24 10" src="https://github.com/apache/knox/assets/34065904/a670c8d7-c3f6-4eb5-a1d1-37a00a272822">
<img width="1779" alt="Screenshot 2023-10-18 at 13 24 21" src="https://github.com/apache/knox/assets/34065904/8cbbf21e-d092-4e0a-bb83-5b0d9eeff87f">
<img width="1776" alt="Screenshot 2023-10-18 at 13 24 31" src="https://github.com/apache/knox/assets/34065904/1776e8f4-4f11-4a86-8515-7ddb016450a6">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-2969 - KnoxSSO Cookies should be ignored while calculating token limit per user [knox]
Posted by "smolnar82 (via GitHub)" <gi...@apache.org>.
smolnar82 merged PR #805:
URL: https://github.com/apache/knox/pull/805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org