[GitHub] [cloudstack] nvazquez commented on a change in pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#discussion_r517435355



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -824,7 +824,7 @@ private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering
         int volumesNumber = 1;
         List<DatadiskTO> templateAsIsDisks = null;
         String configurationId = null;
-        if (template.isDeployAsIs()) {
+        if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {

Review comment:
       I've pushed a fix to check for running SSVMs in the zone as well




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org