[jira] [Commented] (NIFI-2750) Add Optional Column Name Quoting to ConvertJSONToSQL

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577930#comment-15577930 ] 

ASF GitHub Bot commented on NIFI-2750:
--------------------------------------

Github user trixpan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1001#discussion_r83530556
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java ---
    @@ -254,6 +264,9 @@ public void onTrigger(final ProcessContext context, final ProcessSession session
             final boolean failUnmappedColumns = FAIL_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue());
             final boolean warningUnmappedColumns = WARNING_UNMATCHED_COLUMN.getValue().equalsIgnoreCase(context.getProperty(UNMATCHED_COLUMN_BEHAVIOR).getValue());
     
    +        //Escape column names?
    +        final boolean escapeColumnNames = "true".equalsIgnoreCase(context.getProperty(QUOTED_IDENTIFIERS).getValue());
    --- End diff --
    
    nice way of assigning the value! 


> Add Optional Column Name Quoting to ConvertJSONToSQL
> ----------------------------------------------------
>
>                 Key: NIFI-2750
>                 URL: https://issues.apache.org/jira/browse/NIFI-2750
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Peter Wicks
>            Assignee: Peter Wicks
>            Priority: Minor
>
> If a column name happens to also be a SQL reserved word then the SQL generated by ConvertJSONToSQL will be invalid and will fail when it runs.
> By getting and quoting column identifiers (optionally) it will allow users to keep original column names by quoting them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)