You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "ReneEnjilian (via GitHub)" <gi...@apache.org> on 2024/01/24 19:57:57 UTC

[PR] [SYSTEMDS-3666] Simplify Not ('!') over comparisons [systemds]

ReneEnjilian opened a new pull request, #1988:
URL: https://github.com/apache/systemds/pull/1988

   This pull request implements rewrites for the not-operator ('!') applied over comparisons. The implemented rewrites are:
   
   - !(A>B) -> A<=B
   - !(A<B) -> A>=B
   - !(A==B) -> A!=B, including !(A==0) -> A!=0
   
   I changed the last rewrite to a more general version that also covers !(A==0) -> A!=0. I would be grateful for feedback on this matter. Further, testing has been added. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SYSTEMDS-3666] Simplify Not ('!') over comparisons [systemds]

Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 closed pull request #1988: [SYSTEMDS-3666] Simplify Not ('!') over comparisons
URL: https://github.com/apache/systemds/pull/1988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SYSTEMDS-3666] Simplify Not ('!') over comparisons [systemds]

Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #1988:
URL: https://github.com/apache/systemds/pull/1988#issuecomment-1910266945

   Thanks @ReneEnjilian for the continued contributions. I'll have a closer look and merge this in once we cut the release tag (after finishing the remaining bug fixes) just to ensure such new rewrites do not change things last minute.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [SYSTEMDS-3666] Simplify Not ('!') over comparisons [systemds]

Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #1988:
URL: https://github.com/apache/systemds/pull/1988#issuecomment-2002563344

   LGTM. Thanks for the patch @ReneEnjilian - during the merge I only moved the rewrite from dynamic to static rewrites (no size-based decision), tightened the source pattern (only if NOT is the only consumer), and simplified the test (single dml/R file).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org