You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Sachin Goel (JIRA)" <ji...@apache.org> on 2015/07/27 13:50:05 UTC

[jira] [Comment Edited] (FLINK-2404) LongCounters should have an "addValue()" method for primitive longs

    [ https://issues.apache.org/jira/browse/FLINK-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642600#comment-14642600 ] 

Sachin Goel edited comment on FLINK-2404 at 7/27/15 11:49 AM:
--------------------------------------------------------------

In fact, here are some detailed timings under the JavaProgramTestBase cases:
                 No call to add     Add Long       Add long
without reuse:     131.6          122.8        95.8
with reuse:           49.15          43.0         44.35
collection:            78.5            84.9         80.75

[These are timings averaged over 20 runs]


was (Author: sachingoel0101):
In fact, here are some detailed timings under the JavaProgramTestBase cases:
                 No call to add  Add Long   Add long
without reuse:     131.6          122.8        95.8
with reuse:        49.15          43.0         44.35
collection:        78.5           84.9         80.75

[These are timings averaged over 20 runs]

> LongCounters should have an "addValue()" method for primitive longs
> -------------------------------------------------------------------
>
>                 Key: FLINK-2404
>                 URL: https://issues.apache.org/jira/browse/FLINK-2404
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>             Fix For: 0.10
>
>
> Since the LongCounter is used heavily for internal statistics reporting, it must have very low overhead.
> The current "addValue()" method always boxes and unboxes the values, which is unnecessary overhead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)