You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/16 19:15:00 UTC
[jira] [Updated] (ARROW-16424) [C++] Update uri_path parsing in FromProto
[ https://issues.apache.org/jira/browse/ARROW-16424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated ARROW-16424:
-----------------------------------
Labels: pull-request-available substrait (was: substrait)
> [C++] Update uri_path parsing in FromProto
> ------------------------------------------
>
> Key: ARROW-16424
> URL: https://issues.apache.org/jira/browse/ARROW-16424
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Ariana Villegas
> Assignee: Sanjiban Sengupta
> Priority: Minor
> Labels: pull-request-available, substrait
> Time Spent: 10m
> Remaining Estimate: 0h
>
> FromProto function in {{arrow/engine/substrait/relation_internal.cc}} parse {{uri_path}} with {{string_view}} utilities. However this should be done with {{Uri}} class from {{arrow/util/uri.h.}}
> {code:c++}
> else if (util::string_view{path}.ends_with(".arrow")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> } else if (util::string_view{path}.ends_with(".feather")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)