[jira] [Commented] (HBASE-11119) Update ExportSnapShot to optionally not use a tmp file on external file system

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992524#comment-13992524 ] 

Hadoop QA commented on HBASE-11119:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12643889/HBASE-11119.patch
  against trunk revision .
  ATTACHMENT ID: 12643889

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            System.err.println("Unable to remove existing snapshot tmp directory: " + snapshotTmpDir);
+          System.err.println("A snapshot with the same name '"+ snapshotName +"' may be in-progress");
+          System.err.println("Please check " + snapshotTmpDir + ". If the snapshot has completed, ");
+          System.err.println("consider removing "+ snapshotTmpDir +" by using the -overwrite option");

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestMultiParallel

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9481//console

This message is automatically generated.

> Update ExportSnapShot to optionally not use a tmp file on external file system
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-11119
>                 URL: https://issues.apache.org/jira/browse/HBASE-11119
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Ted Malaska
>            Assignee: Ted Malaska
>            Priority: Minor
>         Attachments: HBASE-11119.patch
>
>
> There are FileSystem like S3 where renaming is extremely expensive.  This patch will add a parameter that says something like
> use.tmp.folder
> It will be defaulted to true.  So default behavior is the same.  If false is set them the files will land in the final destination with no need for a rename. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)