You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/10 04:34:49 UTC

[GitHub] [apisix] starsz commented on a change in pull request #4164: feat: add 50x html for error page

starsz commented on a change in pull request #4164:
URL: https://github.com/apache/apisix/pull/4164#discussion_r629042703



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -617,6 +642,17 @@ http {
             proxy_pass $upstream_mirror_host$request_uri;
         }
         {% end %}
+
+        location = /50x.html {

Review comment:
       Not really good to do that.Because we will use "50x.html" to search in the "html" directory.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org