[GitHub] [storm] govind-menon commented on a change in pull request #3184: STORM-3555 add meter to track errors killing workers

[GitBox <gi...@apache.org>]

govind-menon commented on a change in pull request #3184: STORM-3555 add meter to track errors killing workers
URL: https://github.com/apache/storm/pull/3184#discussion_r359008006
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java
 ##########
 @@ -339,6 +342,7 @@ public void launchDaemon() {
             //This will only get updated once
             metricsRegistry.registerMeter("supervisor:num-launched").mark();
             metricsRegistry.registerMeter("supervisor:num-shell-exceptions", ShellUtils.numShellExceptions);
+            killErrorMeter = metricsRegistry.registerMeter("supervisor:num-kill-errors");
 
 Review comment:
   Nit: rename to num-kill-worker-errors

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services