You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Berenguer Blasi (Jira)" <ji...@apache.org> on 2022/05/27 09:23:00 UTC

[jira] [Comment Edited] (CASSANDRA-17232) org.apache.cassandra.db.commitlog.GroupCommitLogTest tests failing on trunk

    [ https://issues.apache.org/jira/browse/CASSANDRA-17232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542845#comment-17542845 ] 

Berenguer Blasi edited comment on CASSANDRA-17232 at 5/27/22 9:22 AM:
----------------------------------------------------------------------

Take2: Both {{shutdown}} and {{closeAndDeleteSegmentUnsafe}} paths could be trying to delete at the same time given the right timing and timeouts. Now it survives 1K runs in CI.

{noformat}
java.io.UncheckedIOException
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:768)
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:753)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:255)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:297)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:304)
	at org.apache.cassandra.io.util.File.delete(File.java:158)
	at org.apache.cassandra.io.util.File.delete(File.java:167)
	at org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.discard(CommitLogSegmentManagerCDC.java:75)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.closeAndDeleteSegmentUnsafe(AbstractCommitLogSegmentManager.java:479)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:452)
	at org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:504)
	at org.apache.cassandra.db.commitlog.CommitLog.resetUnsafe(CommitLog.java:470)
	at org.apache.cassandra.db.commitlog.CommitLogTest.beforeTest(CommitLogTest.java:184)
{noformat}

{noformat}
java.io.UncheckedIOException
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:768)
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:753)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:255)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:297)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:304)
	at org.apache.cassandra.io.util.File.delete(File.java:158)
	at org.apache.cassandra.io.util.File.delete(File.java:167)
	at org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:691)
	at org.apache.cassandra.db.commitlog.CommitLogSegment.discard(CommitLogSegment.java:449)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.discardAvailableSegment(AbstractCommitLogSegmentManager.java:523)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.shutdown(AbstractCommitLogSegmentManager.java:510)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:453)
	at org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:503)
	at org.apache.cassandra.db.commitlog.CommitLog.resetUnsafe(CommitLog.java:469)
	at org.apache.cassandra.db.commitlog.CommitLogTest.beforeTest(CommitLogTest.java:190)
{noformat}




was (Author: bereng):
Take2: Both {{shutdown}} and {{closeAndDeleteSegmentUnsafe}} paths could be trying to delete at the same time given the right timing and timeouts

{noformat}
java.io.UncheckedIOException
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:768)
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:753)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:255)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:297)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:304)
	at org.apache.cassandra.io.util.File.delete(File.java:158)
	at org.apache.cassandra.io.util.File.delete(File.java:167)
	at org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDC.discard(CommitLogSegmentManagerCDC.java:75)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.closeAndDeleteSegmentUnsafe(AbstractCommitLogSegmentManager.java:479)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:452)
	at org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:504)
	at org.apache.cassandra.db.commitlog.CommitLog.resetUnsafe(CommitLog.java:470)
	at org.apache.cassandra.db.commitlog.CommitLogTest.beforeTest(CommitLogTest.java:184)
{noformat}

{noformat}
java.io.UncheckedIOException
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:768)
	at org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:753)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:255)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:297)
	at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:304)
	at org.apache.cassandra.io.util.File.delete(File.java:158)
	at org.apache.cassandra.io.util.File.delete(File.java:167)
	at org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:691)
	at org.apache.cassandra.db.commitlog.CommitLogSegment.discard(CommitLogSegment.java:449)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.discardAvailableSegment(AbstractCommitLogSegmentManager.java:523)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.shutdown(AbstractCommitLogSegmentManager.java:510)
	at org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:453)
	at org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:503)
	at org.apache.cassandra.db.commitlog.CommitLog.resetUnsafe(CommitLog.java:469)
	at org.apache.cassandra.db.commitlog.CommitLogTest.beforeTest(CommitLogTest.java:190)
{noformat}



> org.apache.cassandra.db.commitlog.GroupCommitLogTest tests failing on trunk
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17232
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17232
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> I saw [here|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1344/testReport/junit/org.apache.cassandra.db.commitlog/GroupCommitLogTest/replayWithDiscard_3_/] and [here|https://ci-cassandra.apache.org/job/Cassandra-trunk/881/testReport/junit/org.apache.cassandra.db.commitlog/GroupCommitLogTest/replayWithDiscard_3__compression_3/] the same assertion failure:
>  
> {code:java}
> org.apache.cassandra.db.commitlog.GroupCommitLogTest.replayWithDiscard[3]
> Error Message
> expected:<204> but was:<0>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<204> but was:<0> at org.apache.cassandra.db.commitlog.CommitLogTest.replayWithDiscard(CommitLogTest.java:883)
> {code}
>  
> Then I find that there are many other tests from GroupCommitLogTest failing with No such file found.
> Example:
> https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1344/



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org