[asterixdb] branch master updated: [NO ISSUE][MTD] Use dataverse canonical form in node group name

[mh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mhubail pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 9f8b520  [NO ISSUE][MTD] Use dataverse canonical form in node group name
9f8b520 is described below

commit 9f8b5209e57621954659d68d01a5f6ec72110d0b
Author: Murtadha Hubail <mh...@apache.org>
AuthorDate: Thu Sep 10 15:23:11 2020 +0300

    [NO ISSUE][MTD] Use dataverse canonical form in node group name
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    
    - Use dataverse canonical form in node group name rather
      than the dataverse display name.
    
    Change-Id: I946bd249471b8ac465932cf386fedad93513ea1c
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/7883
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Reviewed-by: Murtadha Hubail <mh...@apache.org>
    Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
---
 .../src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
index 762b9e5..bf3f8cf 100644
--- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
+++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
@@ -597,7 +597,8 @@ public class DatasetUtil {
     public static String createNodeGroupForNewDataset(DataverseName dataverseName, String datasetName,
             long rebalanceCount, Set<String> ncNames, MetadataProvider metadataProvider) throws Exception {
         ICcApplicationContext appCtx = metadataProvider.getApplicationContext();
-        String nodeGroup = dataverseName + "." + datasetName + (rebalanceCount == 0L ? "" : "_" + rebalanceCount);
+        String nodeGroup = dataverseName.getCanonicalForm() + "." + datasetName
+                + (rebalanceCount == 0L ? "" : "_" + rebalanceCount);
         MetadataTransactionContext mdTxnCtx = metadataProvider.getMetadataTxnContext();
         appCtx.getMetadataLockManager().acquireNodeGroupWriteLock(metadataProvider.getLocks(), nodeGroup);
         NodeGroup ng = MetadataManager.INSTANCE.getNodegroup(mdTxnCtx, nodeGroup);