[GitHub] snleee commented on a change in pull request #3869: add config to control kafka fetcher size and increase default

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #3869: add config to control kafka fetcher size and increase default
URL: https://github.com/apache/incubator-pinot/pull/3869#discussion_r261506426
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/kafka/KafkaPartitionLevelConsumer.java
 ##########
 @@ -38,14 +38,21 @@
 public class KafkaPartitionLevelConsumer extends KafkaConnectionHandler implements PartitionLevelConsumer {
   private static final Logger LOGGER = LoggerFactory.getLogger(KafkaPartitionLevelConsumer.class);
 
+  private final int _fetchRequestMinBytes;
+  private final int _fetchRequestSize;
+
   public KafkaPartitionLevelConsumer(String clientId, StreamConfig streamConfig, int partition) {
     super(clientId, streamConfig, partition, new KafkaSimpleConsumerFactoryImpl());
+    this._fetchRequestSize = getkafkaLowLevelStreamConfig().getKafkaFetcherSizeBytes();
+    this._fetchRequestMinBytes = getkafkaLowLevelStreamConfig().getKafkaFetcherMinBytes();
 
 Review comment:
   Same here `fetchRequestMinBytes vs fetcherMinBytes`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org