You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/02 21:56:17 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8713: Split functionality out of views/database/__init__.py, re-enable pylint

codecov-io commented on issue #8713: Split functionality out of views/database/__init__.py, re-enable pylint
URL: https://github.com/apache/incubator-superset/pull/8713#issuecomment-560680025
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8713?src=pr&el=h1) Report
   > Merging [#8713](https://codecov.io/gh/apache/incubator-superset/pull/8713?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ac0e353a542bc6daaa9a5f6ef07459ed7c5b71a4?src=pr&el=desc) will **decrease** coverage by `5.86%`.
   > The diff coverage is `81.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8713/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8713?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8713      +/-   ##
   ==========================================
   - Coverage   71.42%   65.55%   -5.87%     
   ==========================================
     Files         121      482     +361     
     Lines       12790    24083   +11293     
     Branches        0     2763    +2763     
   ==========================================
   + Hits         9135    15788    +6653     
   - Misses       3655     8115    +4460     
   - Partials        0      180     +180
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8713?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `91.11% <ø> (ø)` | :arrow_up: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `93.75% <100%> (+1.44%)` | :arrow_up: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <77.77%> (ø)` | |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `78.94% <78.94%> (ø)` | |
   | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
   | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.46% <0%> (ø)` | |
   | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | |
   | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `80.28% <0%> (ø)` | |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4) | `76.92% <0%> (ø)` | |
   | ... and [361 more](https://codecov.io/gh/apache/incubator-superset/pull/8713/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8713?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8713?src=pr&el=footer). Last update [ac0e353...6eafdfd](https://codecov.io/gh/apache/incubator-superset/pull/8713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org