You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/08/28 02:39:40 UTC
[GitHub] [dubbo-go] YongHaoWu commented on a change in pull request #730: chore: Remove unnecessary return and judgement.
YongHaoWu commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r478798728
##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
"sync"
"unicode"
"unicode/utf8"
-)
-import (
- perrors "github.com/pkg/errors"
-)
-
-import (
"github.com/apache/dubbo-go/common/logger"
+ perrors "github.com/pkg/errors"
Review comment:
@AlexStocks Hi, this is `vim-go` 's behavior. I think it 'll change `import order` sorted by alphabet. Can you accept this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org