You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/21 16:11:31 UTC
[GitHub] [spark] sarutak opened a new pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
sarutak opened a new pull request #29825:
URL: https://github.com/apache/spark/pull/29825
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR reverts SPARK-32886 (#29757) for branch-2.4.
That change needs `appBasePath` in `webui.js` but it's absent for `branch-2.4`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696227516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696219867
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128944/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696218969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696230548
**[Test build #128945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128945/testReport)** for PR 29825 at commit [`c6705a8`](https://github.com/apache/spark/commit/c6705a8599ff99328bfd1ee986744ad471db2b1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696230548
**[Test build #128945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128945/testReport)** for PR 29825 at commit [`c6705a8`](https://github.com/apache/spark/commit/c6705a8599ff99328bfd1ee986744ad471db2b1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696244411
@srowen Thanks. I've reverted it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696226565
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696231064
**[Test build #128945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128945/testReport)** for PR 29825 at commit [`c6705a8`](https://github.com/apache/spark/commit/c6705a8599ff99328bfd1ee986744ad471db2b1c).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696238566
Ah OK, yes let's revert. Feel free to open another PR for branch-2.4 if you're up for it.
The test failure is not related, and another instance of a corrupt Maven dir on Jenkins. @shaneknapp can that be deleted?
So, I'm pretty OK to revert this right away as it clearly passed before the original change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696219860
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696231089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696227516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696231101
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128945/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696231089
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696219716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696219839
**[Test build #128944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128944/testReport)** for PR 29825 at commit [`c6705a8`](https://github.com/apache/spark/commit/c6705a8599ff99328bfd1ee986744ad471db2b1c).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696219716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696218992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696219716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696218992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696218992
**[Test build #128944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128944/testReport)** for PR 29825 at commit [`c6705a8`](https://github.com/apache/spark/commit/c6705a8599ff99328bfd1ee986744ad471db2b1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696219716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696218969
cc: @srowen @Dooyoung-Hwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696238566
Ah OK, yes let's revert. Feel free to open another PR for branch-2.4 if you're up for it.
The test failure is not related, and another instance of a corrupt Maven dir on Jenkins. @shaneknapp can that be deleted?
So, I'm pretty OK to revert this right away as it clearly passed before the original change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #29825:
URL: https://github.com/apache/spark/pull/29825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #29825:
URL: https://github.com/apache/spark/pull/29825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29825: [HOTFIX][2.4] Revert SPARK-32886
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29825:
URL: https://github.com/apache/spark/pull/29825#issuecomment-696218992
**[Test build #128944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128944/testReport)** for PR 29825 at commit [`c6705a8`](https://github.com/apache/spark/commit/c6705a8599ff99328bfd1ee986744ad471db2b1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org