You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/26 11:08:29 UTC
[GitHub] [airflow] potiuk opened a new pull request #18530: Fix intermittent orphan test
potiuk opened a new pull request #18530:
URL: https://github.com/apache/airflow/pull/18530
The orphan scheduler test fails intermittently likely due to
the way how pytest runs child processes. The fix is to run this
test in a fork and pass the result of the test back to the
parent process. This way we can be pretty sure that the process
has no extra children.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #18530: Fix intermittent orphan test
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #18530:
URL: https://github.com/apache/airflow/pull/18530#issuecomment-930978215
@potiuk the `test_no_orphan_process_will_be_left` seems flaky?
I have two PRs that failed on
`tests/jobs/test_scheduler_job.py::TestSchedulerJob::test_no_orphan_process_will_be_left: failed on teardown with "sqlalchemy.exc.OperationalError: (MySQLdb._exceptions.OperationalError) (2013, 'Lost connection to MySQL server during query')`
https://github.com/apache/airflow/pull/18627/checks?check_run_id=3753180091#step:6:11409
https://github.com/apache/airflow/pull/18623/checks?check_run_id=3752080712#step:6:10977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18530: Fix intermittent orphan test
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18530:
URL: https://github.com/apache/airflow/pull/18530#issuecomment-931125920
Yep. Bad idea it seems Reverting in https://github.com/apache/airflow/pull/18631. We'll have to fix it "better". The fork case was really a hack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18530: Fix intermittent orphan test
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18530:
URL: https://github.com/apache/airflow/pull/18530#issuecomment-927321340
Unfortunately MSSQL does not like os._exit(). Maybe I will just skip it there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18530: Fix intermittent orphan test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18530:
URL: https://github.com/apache/airflow/pull/18530#issuecomment-927748031
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18530: Fix intermittent orphan test
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18530:
URL: https://github.com/apache/airflow/pull/18530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org