You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/06 18:40:19 UTC

[GitHub] [incubator-superset] bradgessler opened a new issue #9095: SQL Lab editor cursor position is incorrect in Safari

bradgessler opened a new issue #9095: SQL Lab editor cursor position is incorrect in Safari
URL: https://github.com/apache/incubator-superset/issues/9095
 
 
   When I type a SQL query in SQL Lab with the latest version of Safari Version 13.0.5 (15608.5.11), the cursor doesn't lineup with where I'm actually typing.
   
   ### Expected results
   
   I expect the cursor to remain at the end of the line while I'm typing.
   
   ### Actual results
   
   The cursor slowly starts to fall behind in Safari as I type.
   
   #### Screenshots
   
   A video of the issue may be watched at https://s3.amazonaws.com/bradgessler/Screen-Recording-2020-02-06-at-10.29.14-Z2v0KXdYZrAp.mov
   
   #### How to reproduce the bug
   
   1. Using the latest version of Safari, go to `/superset/sqllab`
   2.Begin typing a query, keep typing at least 40 chars
   3. Observe the cursor fall behind
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   This use to be an issue in Firefox and Chrome, but before submitting this bug I verified this is no longer a problem in those browsers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari
URL: https://github.com/apache/incubator-superset/issues/9095#issuecomment-587512505
 
 
   Maybe @willbarrett could take a look though, is Preset planning on supporting Safari?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] willbarrett commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari

Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari
URL: https://github.com/apache/incubator-superset/issues/9095#issuecomment-587581952
 
 
   I'll redirect that question to @rusackas who's more front-end focused than myself :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] rusackas commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari
URL: https://github.com/apache/incubator-superset/issues/9095#issuecomment-587587514
 
 
   Wow, that looks completely infuriating. I'll try to replicate/fix asap.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9095: SQL Lab editor cursor position is incorrect in Safari
URL: https://github.com/apache/incubator-superset/issues/9095#issuecomment-587512224
 
 
   This looks like a bug in Safari because when keywords are getting bolded, they slightly increase in width but the cursor doesn't move with them. We don't really support Safari that well, so I might recommend using Chrome or Firefox as I can't guarantee that this issue will get attention very quickly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch closed issue #9095: SQL Lab editor cursor position is incorrect in Safari

Posted by GitBox <gi...@apache.org>.
mistercrunch closed issue #9095: SQL Lab editor cursor position is incorrect in Safari
URL: https://github.com/apache/incubator-superset/issues/9095
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org