You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/05 11:58:27 UTC
[GitHub] [arrow] kszucs opened a new pull request #9103: [CI] Use pip to install crossbow's dependencies for the comment bot
kszucs opened a new pull request #9103:
URL: https://github.com/apache/arrow/pull/9103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9103: ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9103:
URL: https://github.com/apache/arrow/pull/9103#issuecomment-754630798
https://issues.apache.org/jira/browse/ARROW-11132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9103: [CI] Use pip to install crossbow's dependencies for the comment bot
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9103:
URL: https://github.com/apache/arrow/pull/9103#issuecomment-754610712
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #9103: ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #9103:
URL: https://github.com/apache/arrow/pull/9103#discussion_r552243059
##########
File path: dev/archery/setup.py
##########
@@ -26,7 +26,9 @@
extras = {
'benchmark': ['pandas'],
- 'bot': ['ruamel.yaml', 'pygithub'],
+ # bot extra includes crossbow's dependencies
Review comment:
It's a good idea, the same has just crossed my mind during working on #9096. Feel free to add it in #8915.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #9103: ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #9103:
URL: https://github.com/apache/arrow/pull/9103#discussion_r551921283
##########
File path: .github/workflows/comment_bot.yml
##########
@@ -34,17 +34,12 @@ jobs:
uses: actions/checkout@v2
with:
path: arrow
- # because libgit2 is a dependency of crossbow so prefer conda
Review comment:
pygit2 ships wheels now with libgit2 bundled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #9103: ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #9103:
URL: https://github.com/apache/arrow/pull/9103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] terencehonles commented on a change in pull request #9103: ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot
Posted by GitBox <gi...@apache.org>.
terencehonles commented on a change in pull request #9103:
URL: https://github.com/apache/arrow/pull/9103#discussion_r552238594
##########
File path: dev/archery/setup.py
##########
@@ -26,7 +26,9 @@
extras = {
'benchmark': ['pandas'],
- 'bot': ['ruamel.yaml', 'pygithub'],
+ # bot extra includes crossbow's dependencies
Review comment:
Might it make sense to separate crossbow's dependencies and specify the install as `arrow/dev/archery[bot,crossbow]`?
That way you could install the dependencies with one of the other extras. This is partially because I'm not sure if I should use `arrow/dev/archery[bot]` for what I'm copying in #8915 from https://github.com/apache/arrow/commit/7f11abee01104fceb47088ea42501935a44b0b36#diff-90e4e8bfd9b23a7b4bf4cfa1cb4bd0d80a87e21ac7fbd3a39c30f19709d4c705R50-R61
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] terencehonles commented on a change in pull request #9103: ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot
Posted by GitBox <gi...@apache.org>.
terencehonles commented on a change in pull request #9103:
URL: https://github.com/apache/arrow/pull/9103#discussion_r552326091
##########
File path: dev/archery/setup.py
##########
@@ -26,7 +26,9 @@
extras = {
'benchmark': ['pandas'],
- 'bot': ['ruamel.yaml', 'pygithub'],
+ # bot extra includes crossbow's dependencies
Review comment:
This is repeated a lot, and I'm probably going to just open a different PR for cleaning up the repeated crossbow dependencies that way #8915 can hopefully be merged in sooner rather than later. It looks like it's built correctly (it was working before Travis disappeared).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org