You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/16 11:50:35 UTC
[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request
#3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
tuohai666 opened a new pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999
Fixes #3968.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3999:
#3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999#issuecomment-575185914
Please set milestone and lable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on a change in pull
request #3999: #3968,
Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999#discussion_r367780624
##########
File path: sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/execute/MySQLComStmtExecutePacket.java
##########
@@ -86,7 +86,7 @@ public MySQLComStmtExecutePacket(final MySQLPacketPayload payload) throws SQLExc
} else {
nullBitmap = null;
newParametersBoundFlag = null;
- parameters = null;
+ parameters = new ArrayList<>(0);;
Review comment:
Yes, it's better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #3999: #3968,
Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999#discussion_r367459209
##########
File path: sharding-proxy/sharding-proxy-transport/sharding-proxy-transport-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/transport/mysql/packet/command/query/binary/execute/MySQLComStmtExecutePacket.java
##########
@@ -86,7 +86,7 @@ public MySQLComStmtExecutePacket(final MySQLPacketPayload payload) throws SQLExc
} else {
nullBitmap = null;
newParametersBoundFlag = null;
- parameters = null;
+ parameters = new ArrayList<>(0);;
Review comment:
How about use Collections.emptyList()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3999:
#3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999#issuecomment-575475111
/run ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3999:
#3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue
#3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #3999: #3968, Ambiguous description of COM_STMT_EXECUTE in MySQL protocol
URL: https://github.com/apache/incubator-shardingsphere/pull/3999#issuecomment-575185914
Please set milestone and label
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services