You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2012/10/31 00:08:14 UTC

[jira] [Commented] (HBASE-6829) [WINDOWS] Tests should ensure that HLog is closed

    [ https://issues.apache.org/jira/browse/HBASE-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487352#comment-13487352 ] 

Ted Yu commented on HBASE-6829:
-------------------------------

{code}
+  public void tearDown() throws IOException {
+    region.close();
+    hlog.close();
{code}
Should region.close() be enclosed in try / catch block ?
If IOE comes out of region.close(), hlog wouldn't be closed, right ?
                
> [WINDOWS] Tests should ensure that HLog is closed
> -------------------------------------------------
>
>                 Key: HBASE-6829
>                 URL: https://issues.apache.org/jira/browse/HBASE-6829
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>              Labels: windows
>         Attachments: hbase-6829_v1-0.94.patch, hbase-6829_v1-trunk.patch, hbase-6829_v2-0.94.patch, hbase-6829_v2-trunk.patch, hbase-6829_v3-0.94.patch, hbase-6829_v3-trunk.patch
>
>
> TestCacheOnWriteInSchema and TestCompactSelection fails with 
> {code}
> java.io.IOException: Target HLog directory already exists: ./target/test-data/2d814e66-75d3-4c1b-92c7-a49d9972e8fd/TestCacheOnWriteInSchema/logs
> 	at org.apache.hadoop.hbase.regionserver.wal.HLog.<init>(HLog.java:385)
> 	at org.apache.hadoop.hbase.regionserver.wal.HLog.<init>(HLog.java:316)
> 	at org.apache.hadoop.hbase.regionserver.TestCacheOnWriteInSchema.setUp(TestCacheOnWriteInSchema.java:162)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira