You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/28 22:58:29 UTC
[GitHub] [spark] amaliujia commented on a diff in pull request #38824: [SPARK-41304][CONNECT] Add missing docs for DataFrame API
amaliujia commented on code in PR #38824:
URL: https://github.com/apache/spark/pull/38824#discussion_r1034135550
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -457,6 +519,31 @@ def sample(
withReplacement: bool = False,
seed: Optional[int] = None,
) -> "DataFrame":
+ """Returns a sampled subset of this :class:`DataFrame`.
+
+ .. versionadded:: 3.4.0
+
+ Parameters
+ ----------
+ withReplacement : bool, optional
+ Sample with replacement or not (default ``False``).
+ fraction : float
+ Fraction of rows to generate, range [0.0, 1.0].
+ seed : int, optional
+ Seed for sampling (default a random seed).
+
+ Returns
+ -------
+ :class:`DataFrame`
+ Sampled rows from given DataFrame.
Review Comment:
I guess this is sampled which is `Rows are sampled from the given DataFrame`
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -457,6 +519,31 @@ def sample(
withReplacement: bool = False,
seed: Optional[int] = None,
) -> "DataFrame":
+ """Returns a sampled subset of this :class:`DataFrame`.
+
+ .. versionadded:: 3.4.0
+
+ Parameters
+ ----------
+ withReplacement : bool, optional
+ Sample with replacement or not (default ``False``).
+ fraction : float
+ Fraction of rows to generate, range [0.0, 1.0].
+ seed : int, optional
+ Seed for sampling (default a random seed).
+
+ Returns
+ -------
+ :class:`DataFrame`
+ Sampled rows from given DataFrame.
Review Comment:
I guess this is sampled which is `Rows are sampled from given DataFrame`
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -457,6 +519,31 @@ def sample(
withReplacement: bool = False,
seed: Optional[int] = None,
) -> "DataFrame":
+ """Returns a sampled subset of this :class:`DataFrame`.
+
+ .. versionadded:: 3.4.0
+
+ Parameters
+ ----------
+ withReplacement : bool, optional
+ Sample with replacement or not (default ``False``).
+ fraction : float
+ Fraction of rows to generate, range [0.0, 1.0].
+ seed : int, optional
+ Seed for sampling (default a random seed).
+
+ Returns
+ -------
+ :class:`DataFrame`
+ Sampled rows from given DataFrame.
Review Comment:
I guess this is sampled which is `Rows are sampled from given DataFrame` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org