[jira] [Work logged] (HADOOP-17872) ABFS: Refactor read flow to include ReadRequestParameter

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-17872?focusedWorklogId=766292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766292 ]

ASF GitHub Bot logged work on HADOOP-17872:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/22 21:16
            Start Date: 04/May/22 21:16
    Worklog Time Spent: 10m 
      Work Description: raymondlam12 commented on code in PR #3344:
URL: https://github.com/apache/hadoop/pull/3344#discussion_r865386021


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -746,14 +747,18 @@ public AbfsRestOperation getPathStatus(final String path, final boolean includeP
     return op;
   }
 
-  public AbfsRestOperation read(final String path, final long position, final byte[] buffer, final int bufferOffset,
-                                final int bufferLength, final String eTag, String cachedSasToken,
+  public AbfsRestOperation read(String path,
+      byte[] buffer,
+      String cachedSasToken,

Review Comment:
   What gets added to the ReadRequestParameters vs in this function signature itself?
   
   Should cachedSasToken be a member of the ReadRequestParameters as well?
   
   Let's make sure these conventions are symmetrical across other RequestParameters as well (ie. AppendRequestParameters). 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 766292)
    Time Spent: 1h  (was: 50m)

> ABFS: Refactor read flow to include ReadRequestParameter
> --------------------------------------------------------
>
>                 Key: HADOOP-17872
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17872
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.4.0
>            Reporter: Sneha Vijayarajan
>            Assignee: Sneha Vijayarajan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> This Jira is to facilitate upcoming work as part of adding an alternate connection :
>  HADOOP-17853 ABFS: Enable optional store connectivity over azure specific protocol for data egress - ASF JIRA (apache.org)
> The scope of the change is to introduce a ReadRequestParameter that will include the various inputs needed for the read request to AbfsClient class.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org