You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/10/24 02:17:35 UTC
[GitHub] sciabarracom commented on a change in pull request #55: Cleaned the
vendor folder
sciabarracom commented on a change in pull request #55: Cleaned the vendor folder
URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/55#discussion_r227623342
##########
File path: examples/golang-hello-vendor/Makefile
##########
@@ -26,8 +26,8 @@ $(SRCZIP): $(SRCS) $(VENDORS)
cd src ; zip ../$(SRCZIP) -r *
clean:
- wsk action delete $(PACKAGE)/$(NAME)
- rm $(BINZIP) $(SRCZIP) package.done
+ -$(WSK)action delete $(PACKAGE)/$(NAME)
Review comment:
Yes, it ignore errors, otherwise if you do not have the actions the main makefile will break at the first run (make clean devel test)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services