[jira] [Commented] (STORM-1016) Generate trident bolt ids with sorted group names

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994503#comment-14994503 ] 

ASF GitHub Bot commented on STORM-1016:
---------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/706#issuecomment-154551301
  
    @victor-wong these changes look good, but would it be cleaner to just use a TreeMap instead of a HashMap?


> Generate trident bolt ids with sorted group names
> -------------------------------------------------
>
>                 Key: STORM-1016
>                 URL: https://issues.apache.org/jira/browse/STORM-1016
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Jiasheng Wang
>
> In genBoltId() method of TridentTopology, groups are stored in HashSet. 
> So everytime I submit my trident topology, I get different id for my component.
> For example, this time my bolt ids are (b-0-abc, b-1-def), next time they are (b-1-abc, b-0-def). 
> It makes harder for users to track their metrics, and the bolt names in UI are changing too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)