You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2020/05/02 00:24:13 UTC

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15848


Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting
......................................................................

IMPALA-9716: Add jitter to the exponential backoff in status reporting

When status reports fail, we use exponential backoff when retrying
sending them. However, currently the backoff is deterministic, leading
to a thundering herd problem where all of the backends for a
particular query may try to report at the same time, the coordinator
is overwhelmed and rejects some of the rpcs, then the backends all
backoff by the same amount and retry sending at the same time, leading
the coordinator to be overwhelmed again.

This patch alleviates this problem by adding some random jitter to the
exponential backoff used when a status report fails.

Change-Id: I16ce8f9b0ac1374653cdca4dc43077d8ad0db5f1
---
M be/src/runtime/query-state.cc
1 file changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/15848/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16ce8f9b0ac1374653cdca4dc43077d8ad0db5f1
Gerrit-Change-Number: 15848
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/15848 )

Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/15848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I16ce8f9b0ac1374653cdca4dc43077d8ad0db5f1
Gerrit-Change-Number: 15848
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9716: Add jitter to the exponential backoff in status reporting

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15848 )

Change subject: IMPALA-9716: Add jitter to the exponential backoff in status reporting
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5934/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15848
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16ce8f9b0ac1374653cdca4dc43077d8ad0db5f1
Gerrit-Change-Number: 15848
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 May 2020 01:09:51 +0000
Gerrit-HasComments: No