You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by "Manamgoda M.G.T.R (JIRA)" <ji...@apache.org> on 2016/06/29 21:22:10 UTC

[jira] [Assigned] (TAVERNA-989) Fix compile errors in taverna-activity-palette-impl

     [ https://issues.apache.org/jira/browse/TAVERNA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Manamgoda M.G.T.R reassigned TAVERNA-989:
-----------------------------------------

    Assignee: Manamgoda M.G.T.R

> Fix compile errors in taverna-activity-palette-impl
> ---------------------------------------------------
>
>                 Key: TAVERNA-989
>                 URL: https://issues.apache.org/jira/browse/TAVERNA-989
>             Project: Apache Taverna
>          Issue Type: Sub-task
>          Components: Taverna Workbench
>    Affects Versions: workbench 3.1.0
>            Reporter: Stian Soiland-Reyes
>            Assignee: Manamgoda M.G.T.R
>            Priority: Blocker
>
> {code}
> [ERROR] COMPILATION ERROR : 
> [INFO] -------------------------------------------------------------
> [ERROR] /home/stain/src/taverna/incubator-taverna-workbench/taverna-activity-palette-impl/src/main/java/org/apache/taverna/servicedescriptions/impl/ServiceDescriptionRegistryImpl.java:[132,53] error: incompatible types: Path cannot be converted to File
> [ERROR] /home/stain/src/taverna/incubator-taverna-workbench/taverna-activity-palette-impl/src/main/java/org/apache/taverna/servicedescriptions/impl/ServiceDescriptionRegistryImpl.java:[187,17] error: no suitable constructor found for File(Path,String)
> [INFO] 2 errors 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Assigned] (TAVERNA-989) Fix compile errors in taverna-activity-palette-impl

Posted by Stian Soiland-Reyes <st...@apache.org>.
Thanks! I've merged your pull requests.

Perhaps ActivityPaletteConfigurationTest needs to be updated as well.


It could also be that fixing the compile errors reveal others modules
in error that were previously "SKIPPED" and not listed in
https://issues.apache.org/jira/browse/TAVERNA-988 - let's just add
them as subtasks if we find any.


On 29 June 2016 at 23:35, Thilina Manamgoda <ma...@gmail.com> wrote:
> Hi,
>
> I have fixed the bug in ServiceDescriptionRegistryImpl class. i found this
> bug when i try to build,
>
>  Compilation failure:
> [ERROR]
> /home/maanadev/Developer/MyGSOCAPACHE/incubator-taverna-workbench/taverna-activity-palette-impl/src/test/java/org/apache/taverna/workbench/ui/activitypalette/ActivityPaletteConfigurationTest.java:[49,15]
> error: getApplicationHomeDir() in <anonymous
> org.apache.taverna.workbench.ui.activitypalette.ActivityPaletteConfigurationTest$1>
> cannot implement getApplicationHomeDir() in ApplicationConfiguration
> [ERROR] return type File is not compatible with Path
> [ERROR]
> /home/maanadev/Developer/MyGSOCAPACHE/incubator-taverna-workbench/taverna-activity-palette-impl/src/test/java/org/apache/taverna/workbench/ui/activitypalette/ActivityPaletteConfigurationTest.java:[48,3]
> error: method does not override or implement a method from a supertype
>
> i have created a PR for TAVERNA-989
>
> regards,
> Thilina.
>
> On Thu, Jun 30, 2016 at 2:52 AM, Manamgoda M.G.T.R (JIRA) <ji...@apache.org>
> wrote:
>
>>
>>      [
>> https://issues.apache.org/jira/browse/TAVERNA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Manamgoda M.G.T.R reassigned TAVERNA-989:
>> -----------------------------------------
>>
>>     Assignee: Manamgoda M.G.T.R
>>
>> > Fix compile errors in taverna-activity-palette-impl
>> > ---------------------------------------------------
>> >
>> >                 Key: TAVERNA-989
>> >                 URL: https://issues.apache.org/jira/browse/TAVERNA-989
>> >             Project: Apache Taverna
>> >          Issue Type: Sub-task
>> >          Components: Taverna Workbench
>> >    Affects Versions: workbench 3.1.0
>> >            Reporter: Stian Soiland-Reyes
>> >            Assignee: Manamgoda M.G.T.R
>> >            Priority: Blocker
>> >
>> > {code}
>> > [ERROR] COMPILATION ERROR :
>> > [INFO] -------------------------------------------------------------
>> > [ERROR]
>> /home/stain/src/taverna/incubator-taverna-workbench/taverna-activity-palette-impl/src/main/java/org/apache/taverna/servicedescriptions/impl/ServiceDescriptionRegistryImpl.java:[132,53]
>> error: incompatible types: Path cannot be converted to File
>> > [ERROR]
>> /home/stain/src/taverna/incubator-taverna-workbench/taverna-activity-palette-impl/src/main/java/org/apache/taverna/servicedescriptions/impl/ServiceDescriptionRegistryImpl.java:[187,17]
>> error: no suitable constructor found for File(Path,String)
>> > [INFO] 2 errors
>> > {code}
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>



-- 
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718

Re: [jira] [Assigned] (TAVERNA-989) Fix compile errors in taverna-activity-palette-impl

Posted by Thilina Manamgoda <ma...@gmail.com>.
Hi,

I have fixed the bug in ServiceDescriptionRegistryImpl class. i found this
bug when i try to build,

 Compilation failure:
[ERROR]
/home/maanadev/Developer/MyGSOCAPACHE/incubator-taverna-workbench/taverna-activity-palette-impl/src/test/java/org/apache/taverna/workbench/ui/activitypalette/ActivityPaletteConfigurationTest.java:[49,15]
error: getApplicationHomeDir() in <anonymous
org.apache.taverna.workbench.ui.activitypalette.ActivityPaletteConfigurationTest$1>
cannot implement getApplicationHomeDir() in ApplicationConfiguration
[ERROR] return type File is not compatible with Path
[ERROR]
/home/maanadev/Developer/MyGSOCAPACHE/incubator-taverna-workbench/taverna-activity-palette-impl/src/test/java/org/apache/taverna/workbench/ui/activitypalette/ActivityPaletteConfigurationTest.java:[48,3]
error: method does not override or implement a method from a supertype

i have created a PR for TAVERNA-989

regards,
Thilina.

On Thu, Jun 30, 2016 at 2:52 AM, Manamgoda M.G.T.R (JIRA) <ji...@apache.org>
wrote:

>
>      [
> https://issues.apache.org/jira/browse/TAVERNA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Manamgoda M.G.T.R reassigned TAVERNA-989:
> -----------------------------------------
>
>     Assignee: Manamgoda M.G.T.R
>
> > Fix compile errors in taverna-activity-palette-impl
> > ---------------------------------------------------
> >
> >                 Key: TAVERNA-989
> >                 URL: https://issues.apache.org/jira/browse/TAVERNA-989
> >             Project: Apache Taverna
> >          Issue Type: Sub-task
> >          Components: Taverna Workbench
> >    Affects Versions: workbench 3.1.0
> >            Reporter: Stian Soiland-Reyes
> >            Assignee: Manamgoda M.G.T.R
> >            Priority: Blocker
> >
> > {code}
> > [ERROR] COMPILATION ERROR :
> > [INFO] -------------------------------------------------------------
> > [ERROR]
> /home/stain/src/taverna/incubator-taverna-workbench/taverna-activity-palette-impl/src/main/java/org/apache/taverna/servicedescriptions/impl/ServiceDescriptionRegistryImpl.java:[132,53]
> error: incompatible types: Path cannot be converted to File
> > [ERROR]
> /home/stain/src/taverna/incubator-taverna-workbench/taverna-activity-palette-impl/src/main/java/org/apache/taverna/servicedescriptions/impl/ServiceDescriptionRegistryImpl.java:[187,17]
> error: no suitable constructor found for File(Path,String)
> > [INFO] 2 errors
> > {code}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>