[GitHub] nifi pull request #1161: NIFI-2950 Adding support for whole number hex value...

[olegz <gi...@git.apache.org>]

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1161#discussion_r86192691
  
    --- Diff: nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/FromRadixEvaluator.java ---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.attribute.expression.language.evaluation.functions;
    +
    +import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
    +import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
    +import org.apache.nifi.attribute.expression.language.evaluation.WholeNumberEvaluator;
    +import org.apache.nifi.attribute.expression.language.evaluation.WholeNumberQueryResult;
    +
    +import java.util.Map;
    +
    +public class FromRadixEvaluator extends WholeNumberEvaluator {
    +
    +    private final Evaluator<String> numberEvaluator;
    +    private final Evaluator<Long> radixEvaluator;
    +
    +    public FromRadixEvaluator(final Evaluator<String> subject, final Evaluator<Long> radixEvaluator) {
    +        this.numberEvaluator = subject;
    +        this.radixEvaluator = radixEvaluator;
    +    }
    +
    +    @Override
    +    public QueryResult<Long> evaluate(final Map<String, String> attributes) {
    +        final String result = numberEvaluator.evaluate(attributes).getValue();
    --- End diff --
    
    Given that this is a public method, consider null check on ```attributes``` to avoid NPE unless this class is not considered to be part of public API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---