[incubator-superset] branch master updated: [bugfix] fails on None view_menu (#3155)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new d7e4191  [bugfix]  fails on None view_menu (#3155)
d7e4191 is described below

commit d7e419127c71c97580b00c8dae5fc14eb054a312
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Tue Jul 18 19:42:20 2017 -0700

    [bugfix]  fails on None view_menu (#3155)
    
    * [bugfix]  fails on None view_menu
    
    * Update coveralls token
---
 .coveralls.yml       | 2 +-
 superset/security.py | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.coveralls.yml b/.coveralls.yml
index 273f84b..e916d8e 100644
--- a/.coveralls.yml
+++ b/.coveralls.yml
@@ -1 +1 @@
-repo_token: eESbYiv4An6KEvjpmguDs4L7YkubXbqn1
+repo_token: 4P9MpvLrZfJKzHdGZsdV3MzO43OZJgYFn 
diff --git a/superset/security.py b/superset/security.py
index 5878ea0..9a01d6b 100644
--- a/superset/security.py
+++ b/superset/security.py
@@ -164,7 +164,8 @@ def create_missing_perms():
         "Fetching a set of all perms to lookup which ones are missing")
     all_pvs = set()
     for pv in sm.get_session.query(sm.permissionview_model).all():
-        all_pvs.add((pv.permission.name, pv.view_menu.name))
+        if pv.permission and pv.view_menu:
+            all_pvs.add((pv.permission.name, pv.view_menu.name))
 
     def merge_pv(view_menu, perm):
         """Create permission view menu only if it doesn't exist"""

-- 
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <co...@superset.apache.org>'].