You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2010/05/07 14:42:47 UTC
[jira] Created: (QPID-2586) Give Client 0-10 close semantics not
detach
Give Client 0-10 close semantics not detach
-------------------------------------------
Key: QPID-2586
URL: https://issues.apache.org/jira/browse/QPID-2586
Project: Qpid
Issue Type: Improvement
Reporter: Martin Ritchie
Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2586) Give Client 0-10 close semantics not
detach
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-2586:
---------------------------------
Status: Ready To Review (was: In Progress)
> Give Client 0-10 close semantics not detach
> -------------------------------------------
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
> Issue Type: Improvement
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
> The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2586) Give Client 0-10 close semantics not
detach
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868613#action_12868613 ]
Martin Ritchie commented on QPID-2586:
--------------------------------------
The correct thing to do would be to make the client handle the SessionRequestTimeout frames:
IoReceiver - localhost/127.0.0.1:15672 2010-05-18 12:46:09,734 WARN [apache.qpid.transport.SessionDelegate] UNHANDLED: [ssn:"2864ea02-fe24-4d09-803f-6ec2f385314d"] ch=0 SessionRequestTimeout(timeout=0)
> Give Client 0-10 close semantics not detach
> -------------------------------------------
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
> The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2586) Give Client 0-10 close semantics not
detach
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-2586:
---------------------------------
Component/s: Java Client
> Give Client 0-10 close semantics not detach
> -------------------------------------------
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
> The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2586) Give Client 0-10 close semantics not
detach
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-2586:
------------------------------------
Assignee: Martin Ritchie
> Give Client 0-10 close semantics not detach
> -------------------------------------------
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
> Issue Type: Improvement
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
> The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2586) Give Client 0-10 close semantics not
detach
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868636#action_12868636 ]
Rajith Attapattu commented on QPID-2586:
----------------------------------------
Rafi did have a fix for this, but didn't want to commit it just before he went on vacation.
Unless there is some serious side effect (that I am unaware of) that needs to be fixed urgently, I would like to allow him to put in his fix when he comes back.
> Give Client 0-10 close semantics not detach
> -------------------------------------------
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
> Issue Type: Improvement
> Components: Java Client
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
> The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2586) Give Client 0-10 close semantics not
detach
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-2586:
---------------------------------
Status: Open (was: Ready To Review)
Change causes 0-10 C++ broker failures.
> Give Client 0-10 close semantics not detach
> -------------------------------------------
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
> Issue Type: Improvement
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
> The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2586) Give Client 0-10 close semantics not
detach
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867564#action_12867564 ]
Rajith Attapattu commented on QPID-2586:
----------------------------------------
Martin,
The change you made in rev 942098 is causing all the failover tests to fail.
This is due to the session immediately going in to a CLOSED state (instead of DETACHED) and not allowing it to reattach when the connection is created.
I know you sent an email on the dev list regarding this, but I somehow missed it.
Anyways as a rule of thumb, if the 0-10 code path is changed, then it's best if the cpp test profile is run.
May I request you to revert the change as failover is completely broken here?
Perhaps we can try to figure out another way to fix the issue you raised in this JIRA.
Regards,
Rajith
> Give Client 0-10 close semantics not detach
> -------------------------------------------
>
> Key: QPID-2586
> URL: https://issues.apache.org/jira/browse/QPID-2586
> Project: Qpid
> Issue Type: Improvement
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Currently the way the 0-10 java client creates a session actually means that on close the sessions should detach not close.
> Setting the timeout to 0 on creation will result in it performing a close. The code currently actually performs a close rather than a detach as detach has not been implemented.
> The setting of the initial timeout to 0 will just mean the client's current behaviour is reflected in correctly in the protocol frames it sends.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org