You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "findingrish (via GitHub)" <gi...@apache.org> on 2024/08/21 05:58:44 UTC

[PR] Add new standard IT groups (druid)

findingrish opened a new pull request, #16933:
URL: https://github.com/apache/druid/pull/16933

   - Add new groups to run HDFS Azure & GCS IT separately. 
   - Changes in Hadoop Dockerfile to fix build issues. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] Remove migrated deep storage standard ITs (druid)

Posted by "findingrish (via GitHub)" <gi...@apache.org>.
findingrish commented on code in PR #16933:
URL: https://github.com/apache/druid/pull/16933#discussion_r1743503782


##########
examples/quickstart/tutorial/hadoop/docker/Dockerfile:
##########
@@ -19,6 +19,11 @@ FROM centos:7
 
 USER root
 
+# CentOS is EOL, have to use vault
+RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo
+

Review Comment:
   Raised separate here https://github.com/apache/druid/pull/16999. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] Remove migrated deep storage standard ITs (druid)

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz merged PR #16933:
URL: https://github.com/apache/druid/pull/16933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] Remove migrated deep storage standard ITs (druid)

Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on code in PR #16933:
URL: https://github.com/apache/druid/pull/16933#discussion_r1739599520


##########
examples/quickstart/tutorial/hadoop/docker/Dockerfile:
##########
@@ -19,6 +19,11 @@ FROM centos:7
 
 USER root
 
+# CentOS is EOL, have to use vault
+RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo
+

Review Comment:
   I think this warrants a separate PR with a clear explanation of what is being done here.
   The rest of the changes look good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] Remove migrated deep storage standard ITs (druid)

Posted by "findingrish (via GitHub)" <gi...@apache.org>.
findingrish commented on code in PR #16933:
URL: https://github.com/apache/druid/pull/16933#discussion_r1743461340


##########
examples/quickstart/tutorial/hadoop/docker/Dockerfile:
##########
@@ -19,6 +19,11 @@ FROM centos:7
 
 USER root
 
+# CentOS is EOL, have to use vault
+RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo
+

Review Comment:
   Reverted changes in this file. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] Remove migrated deep storage standard ITs (druid)

Posted by "findingrish (via GitHub)" <gi...@apache.org>.
findingrish commented on code in PR #16933:
URL: https://github.com/apache/druid/pull/16933#discussion_r1743461340


##########
examples/quickstart/tutorial/hadoop/docker/Dockerfile:
##########
@@ -19,6 +19,11 @@ FROM centos:7
 
 USER root
 
+# CentOS is EOL, have to use vault
+RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo
+

Review Comment:
   Remove the changes in this file. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

Re: [PR] Remove migrated deep storage standard ITs (druid)

Posted by "findingrish (via GitHub)" <gi...@apache.org>.
findingrish commented on code in PR #16933:
URL: https://github.com/apache/druid/pull/16933#discussion_r1743503782


##########
examples/quickstart/tutorial/hadoop/docker/Dockerfile:
##########
@@ -19,6 +19,11 @@ FROM centos:7
 
 USER root
 
+# CentOS is EOL, have to use vault
+RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/*.repo && \
+    sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo
+

Review Comment:
   Raised separate PR here https://github.com/apache/druid/pull/16999. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org