You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/01 05:28:31 UTC

[GitHub] [hudi] zhangyue19921010 opened a new pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

zhangyue19921010 opened a new pull request #3897:
URL: https://github.com/apache/hudi/pull/3897


   ## What is the purpose of the pull request
   When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.
   
   For current master branch 
   Exception mentioned blow will throw even though disabled auto clean.
   ```
   java.lang.IllegalArgumentException: Increase hoodie.keep.min.commits=3 to be greater than hoodie.cleaner.commits.retained=10. Otherwise, there is risk of incremental pull missing data from few instants.
   	at org.apache.hudi.common.util.ValidationUtils.checkArgument(ValidationUtils.java:40)
   	at org.apache.hudi.config.HoodieCompactionConfig$Builder.build(HoodieCompactionConfig.java:355)
   	at org.apache.hudi.config.HoodieWriteConfig$Builder.setDefaults(HoodieWriteConfig.java:1396)
   	at org.apache.hudi.config.HoodieWriteConfig$Builder.build(HoodieWriteConfig.java:1436)
   	at org.apache.hudi.DataSourceUtils.createHoodieConfig(DataSourceUtils.java:188)
   	at org.apache.hudi.DataSourceUtils.createHoodieClient(DataSourceUtils.java:193)
   	at org.apache.hudi.HoodieSparkSqlWriter$$anonfun$3.apply(HoodieSparkSqlWriter.scala:166)
   	at org.apache.hudi.HoodieSparkSqlWriter$$anonfun$3.apply(HoodieSparkSqlWriter.scala:166)
   	at scala.Option.getOrElse(Option.scala:121)
   	at org.apache.hudi.HoodieSparkSqlWriter$.write(HoodieSparkSqlWriter.scala:166)
   	at org.apache.hudi.DefaultSource.createRelation(DefaultSource.scala:145)
   	at org.apache.spark.sql.execution.datasources.SaveIntoDataSourceCommand.run(SaveIntoDataSourceCommand.scala:45)
   	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:70)
   	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:68)
   	at org.apache.spark.sql.execution.command.ExecutedCommandExec.doExecute(commands.scala:86)
   	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
   	at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
   	at org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
   	at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
   	at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152)
   	at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127)
   	at org.apache.spark.sql.execution.QueryExecution.toRdd$lzycompute(QueryExecution.scala:80)
   	at org.apache.spark.sql.execution.QueryExecution.toRdd(QueryExecution.scala:80)
   	at org.apache.spark.sql.DataFrameWriter$$anonfun$runCommand$1.apply(DataFrameWriter.scala:676)
   	at org.apache.spark.sql.DataFrameWriter$$anonfun$runCommand$1.apply(DataFrameWriter.scala:676)
   	at org.apache.spark.sql.execution.SQLExecution$$anonfun$withNewExecutionId$1.apply(SQLExecution.scala:78)
   	at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:125)
   	at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:73)
   	at org.apache.spark.sql.DataFrameWriter.runCommand(DataFrameWriter.scala:676)
   	at org.apache.spark.sql.DataFrameWriter.saveToV1Source(DataFrameWriter.scala:285)
   	at org.apache.spark.sql.DataFrameWriter.save(DataFrameWriter.scala:271)
   	at org.apache.spark.sql.DataFrameWriter.save(DataFrameWriter.scala:229)
   	at tv.freewheel.reporting.ssql.sinkers.HudiSinker.sink(HudiSinker.scala:20)
   	at tv.freewheel.reporting.realtime.core.schedulers.RuleScheduler$$anonfun$execSink$1$$anonfun$apply$1.apply$mcV$sp(RuleScheduler.scala:73)
   	at tv.freewheel.reporting.realtime.utils.Misc$.failFast(Misc.scala:72)
   	at tv.freewheel.reporting.realtime.core.schedulers.RuleScheduler$$anonfun$execSink$1.apply(RuleScheduler.scala:73)
   	at tv.freewheel.reporting.realtime.core.schedulers.RuleScheduler$$anonfun$execSink$1.apply(RuleScheduler.scala:71)
   	at scala.Option.foreach(Option.scala:257)
   	at tv.freewheel.reporting.realtime.core.schedulers.RuleScheduler.execSink(RuleScheduler.scala:71)
   	at tv.freewheel.reporting.realtime.core.schedulers.RuleScheduler$$anonfun$submitRecursively$3$$anonfun$1.apply$mcV$sp(RuleScheduler.scala:35)
   	at tv.freewheel.reporting.realtime.utils.Misc$$anon$2.run(Misc.scala:31)
   	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
   	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   	at java.lang.Thread.run(Thread.java:748)
   ```
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957025428






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-958782891


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103) 
   * 1e6c7fedbef87cab4843eab4831202db437118e0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-961588774


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-963749964


   Hi @xushiyan Friendly ping. Could you please take a look at this PR at you convince?  Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-1001945401


   Hi @xushiyan Thanks a lot for your explaining.  I will close this pr and keep the behavior as before :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-983251919


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3905",
       "triggerID" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   * 3025fe43776e63a4d96cddd0357e1f0ec76eff35 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3905) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-959482132


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957143790






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-956043709


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] xushiyan commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-1001941431


   @zhangyue19921010 I think putting this conditional validity could compromise the integrity of min-instant as user can toggle auto clean any time. What if on the same table there is a writer and a compactor with different auto clean settings: the writer could disable auto clean and trigger archival and have less number of commits, then compactor runs and see actual instants less than min-instants? I found having consistency over the logic here is important.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-956043709


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957025428


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 closed pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 closed pull request #3897:
URL: https://github.com/apache/hudi/pull/3897


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-961588774


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957143790


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-958782891






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103) 
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957143790






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-958782891






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-983298086


   Just fix conflict from master @xushiyan PTAL :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-1001894159


   > @zhangyue19921010 thanks for the patch. Can you explain what is the downside of keep the logic as is? in another word: even if auto clean disabled, why wouldn't you increase min instants to keep to be greater than commits retained?
   
   Hi @xushiyan Thanks a lot for your attention. Actually this is a minor patch, and just make hudi‘s behavior maybe more appropriate. 
   If I must point a downside, it maybe trouble users who are doing or and writing UTs for archival which need to take care of the min-instants/commits-retained even they disable auto clean :) Just nit patch here I had to say.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-956043709






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-958782891






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-961588774


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-961588774


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-983250066


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   * 3025fe43776e63a4d96cddd0357e1f0ec76eff35 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-983251919


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3905",
       "triggerID" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   * 3025fe43776e63a4d96cddd0357e1f0ec76eff35 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3905) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-983250066


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   * 3025fe43776e63a4d96cddd0357e1f0ec76eff35 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957025428






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 1e6c7fedbef87cab4843eab4831202db437118e0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957143790


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-958782891


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-983281099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3048",
       "triggerID" : "957143790",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3103",
       "triggerID" : "958782891",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3109",
       "triggerID" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1e6c7fedbef87cab4843eab4831202db437118e0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3120",
       "triggerID" : "959482132",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3905",
       "triggerID" : "3025fe43776e63a4d96cddd0357e1f0ec76eff35",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3025fe43776e63a4d96cddd0357e1f0ec76eff35 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3905) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031",
       "triggerID" : "957025428",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3031) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002",
       "triggerID" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004",
       "triggerID" : "956043709",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 3b77c9e8123fa8af3c0dc9aca8c3ec1568c9bd7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3002) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3004) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-956043709






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957025428


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
zhangyue19921010 removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-957143790






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3897:
URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org