[GitHub] [superset] zhaoyongjie edited a comment on pull request #13340: feat: Implement drag and drop columns for filters

[GitBox <gi...@apache.org>]

zhaoyongjie edited a comment on pull request #13340:
URL: https://github.com/apache/superset/pull/13340#issuecomment-786627899


   I personally suggest not to make generic components now. The main reason is that these components are completely inconsistent in function, and we should not do such maintenance that increases complexity.
   
   #### For dimension(group by) selector
   1. columns (can shift between)
   2. Level columns(AKA hierarchy) (there may be folding between levels, can not shift between)
   3. [columns set](https://help.tableau.com/current/pro/desktop/en-us/sortgroup_sets_create.htm)(such as generate `case...when...` clause)
   
   #### For filter selector, Superset is now just a simple dimension filter
   1. If we want to drag saved_metric to generate a having clause,  we need to enable metic drop to filter
   2. columns, or top level of hierarchy
   3. Drag into different types of columns should have different filter
   
   #### For metric selector
   1. columns ( generate ad-hoc metric)
   2. saved_metric
   
   Maybe I have some inconsiderate for consider. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org