You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2012/04/18 16:54:36 UTC

Review Request: When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/
-----------------------------------------------------------

Review request for shindig and Dan Dumont.


Summary
-------

If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.


This addresses bug SHINDIG-1752.
    https://issues.apache.org/jira/browse/SHINDIG-1752


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802 

Diff: https://reviews.apache.org/r/4789/diff


Testing
-------

Ran unit tests


Thanks,

Ryan

Re: Review Request: When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value

Posted by Dan Dumont <dd...@us.ibm.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/#review7005
-----------------------------------------------------------

Ship it!


LGTM, thanks for fixing this.

- Dan


On 2012-04-18 14:54:36, Ryan Baxter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4789/
> -----------------------------------------------------------
> 
> (Updated 2012-04-18 14:54:36)
> 
> 
> Review request for shindig and Dan Dumont.
> 
> 
> Summary
> -------
> 
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
> 
> 
> This addresses bug SHINDIG-1752.
>     https://issues.apache.org/jira/browse/SHINDIG-1752
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802 
> 
> Diff: https://reviews.apache.org/r/4789/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests
> 
> 
> Thanks,
> 
> Ryan
> 
>

Re: Review Request: When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value

Posted by Ryan Baxter <rb...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/#review7007
-----------------------------------------------------------


Committed revision 1327569

- Ryan


On 2012-04-18 14:54:36, Ryan Baxter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4789/
> -----------------------------------------------------------
> 
> (Updated 2012-04-18 14:54:36)
> 
> 
> Review request for shindig and Dan Dumont.
> 
> 
> Summary
> -------
> 
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
> 
> 
> This addresses bug SHINDIG-1752.
>     https://issues.apache.org/jira/browse/SHINDIG-1752
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802 
> 
> Diff: https://reviews.apache.org/r/4789/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests
> 
> 
> Thanks,
> 
> Ryan
> 
>

Re: Review Request: When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value

Posted by Stanton Sievers <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/#review7006
-----------------------------------------------------------

Ship it!


+1

- Stanton


On 2012-04-18 14:54:36, Ryan Baxter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4789/
> -----------------------------------------------------------
> 
> (Updated 2012-04-18 14:54:36)
> 
> 
> Review request for shindig and Dan Dumont.
> 
> 
> Summary
> -------
> 
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
> 
> 
> This addresses bug SHINDIG-1752.
>     https://issues.apache.org/jira/browse/SHINDIG-1752
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802 
> 
> Diff: https://reviews.apache.org/r/4789/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests
> 
> 
> Thanks,
> 
> Ryan
> 
>