[GitHub] [tvm] areusch commented on a change in pull request #8144: [Docker] Add external directory mount

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #8144:
URL: https://github.com/apache/tvm/pull/8144#discussion_r643222899



##########
File path: docker/bash.sh
##########
@@ -46,6 +46,16 @@ if [[ "$1" == "--net=host" ]]; then
     shift 1
 fi
 
+# Mount external directory to the docker
+CI_DOCKER_MOUNT_DIR=( )
+CI_DOCKER_MOUNT_CMD=""
+if [[ "$1" == "--mount" ]]; then
+    shift 1
+    CI_DOCKER_MOUNT_DIR+="$1"
+    shift 1
+    CI_DOCKER_MOUNT_CMD="--mount type=bind,source=${CI_DOCKER_MOUNT_DIR},target=${CI_DOCKER_MOUNT_DIR}"

Review comment:
       i guess this is the same as `-v`, but wondering if we should be consistent everywhere and use `-v` here in case there are differences in the way those two options are handled with past versions of docker?
   
   also, can you use array syntax and quote, in case CI_DOCKER_MOUNT_DIR contains spaces?
   `CI_DOCKER_MOUNT_CMD=( "--mount" "type=bind,source=${CI_DOCKER_MOUNT_DIR},target=${CI_DOCKER_MOUNT_DIR}" )`
   
   and later:
   `"${CI_DOCKER_MOUNT_CMD[@]}"`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org