You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by rajarajan-g <gi...@git.apache.org> on 2016/08/10 08:46:03 UTC

[GitHub] zeppelin pull request #1313: [ZEPPELIN-1245] Focus first paragraph after not...

GitHub user rajarajan-g opened a pull request:

    https://github.com/apache/zeppelin/pull/1313

    [ZEPPELIN-1245] Focus first paragraph after notebook creation

    ### What is this PR for?
    Once the notebook is created, cursor should focus on the first paragraph
    
    
    ### What type of PR is it?
    Bug Fix 
    
    ### Todos
    * [ ] - None
    
    ### What is the Jira issue?
     https://issues.apache.org/jira/browse/ZEPPELIN-1245
    
    ### How should this be tested?
    Once the Zeppelin server is started , Create a new notebook
    check if cursor blinks on the first paragraph of the notebook
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1245

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1313
    
----
commit 5875bc8ab5e04849e4f806c433bf32c7449693dc
Author: rajarajan-g <ra...@imaginea.com>
Date:   2016-08-10T08:41:12Z

    fix for ZEPPELIN-1245

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1313
  
    I agree too.
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1313
  
    @rajarajan-g Can you tell me your Jira username?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1313
  
    Erratum, I was testing master branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...

Posted by rajarajan-g <gi...@git.apache.org>.

Github user rajarajan-g commented on the issue:

    https://github.com/apache/zeppelin/pull/1313
  
    @Leemoonsoo : Thanks for reviewing the code
    
    I did check the existing behaviour , for existing note it doesn't focus to any paragraph.
    
    So,I did code changes now in such way, if we create notebook/open an existing notebook, it will focus on the first paragraph.
    
    For existing notebook, i do focus to end of the paragraph.I hope those changes are fine.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...

Posted by rajarajan-g <gi...@git.apache.org>.

Github user rajarajan-g commented on the issue:

    https://github.com/apache/zeppelin/pull/1313
  
    In my opinion, since the editor itself is not available, it shouldn't focus that paragraph which is also behaviour after this PR
    
    If you/other folks have any other opinions, please let me know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...

Posted by rajarajan-g <gi...@git.apache.org>.

Github user rajarajan-g commented on the issue:

    https://github.com/apache/zeppelin/pull/1313
  
    its 'thinktank'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1313: [ZEPPELIN-1245] Focus first paragraph after notebook c...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1313
  
    In the case that the 1st paragraph's editor is hidden, it doesn't select. Do we care?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---