[jira] [Commented] (NIFI-5336) Remove hbase-server dependency from Hive 3 bundles

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522695#comment-16522695 ] 

ASF GitHub Bot commented on NIFI-5336:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2811

    NIFI-5336: Exclude hbase-server from Hive 3 bundle

    I tested this by visually verifying the dependency is not in the NAR and creating a Hive table (backed by HBase) using PutHive3QL.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5336

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2811
    
----
commit 3c74953018ec2d8d387de47498f0f765c0a3620f
Author: Matthew Burgess <ma...@...>
Date:   2018-06-25T19:07:05Z

    NIFI-5336: Exclude hbase-server from Hive 3 bundle

----


> Remove hbase-server dependency from Hive 3 bundles
> --------------------------------------------------
>
>                 Key: NIFI-5336
>                 URL: https://issues.apache.org/jira/browse/NIFI-5336
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> hbase-server-2.0.0.0-alpha4 is a dependency being transitively brought in by hive-jdbc in the Hive 3 processors module. That dependency is unnecessary for NiFi (as it is a client and does not need server dependencies), and its POM adds a local folder as a Maven repository, which causes the directory to be created at the top-level NiFi folder as well as the nifi-hive3-processors folder, which are also unnecessary.
> Removing this dependency via explicit exclusion will reduce the size of the Hive 3 NAR as well as prevent the build from creating the unnecessary folders.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)