You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/01 15:26:57 UTC

[GitHub] [iceberg] szehon-ho edited a comment on pull request #2266: Implement python drop_table

szehon-ho edited a comment on pull request #2266:
URL: https://github.com/apache/iceberg/pull/2266#issuecomment-811984121


   @rymurr implemented the set, also add a set lock to protect.  I split _delete_files into a separate class as linter was complaining that the method was too complex.
   
   The alternate is to have a filter method like `delete_pool.map(delete_files, filter(...))` , but I guess it's a bit similar to what I had much earlier, so I wrote it more what you suggested.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org