You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/25 06:16:11 UTC

[GitHub] [incubator-kyuubi] Yikf opened a new pull request, #3333: [KYUUBI #3217][FOLLOWUP] Bump ranger version to 2.3.0

Yikf opened a new pull request, #3333:
URL: https://github.com/apache/incubator-kyuubi/pull/3333

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Fix https://github.com/apache/incubator-kyuubi/issues/3217#issuecomment-1219271537
   
   This pr aims to bump ranger version from 2.2.0 to 2.3.0
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3333: Bump ranger version from 2.2.0 to 2.3.0

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3333:
URL: https://github.com/apache/incubator-kyuubi/pull/3333#issuecomment-1227226176

   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3333: [KYUUBI #3217][FOLLOWUP] Bump ranger version to 2.3.0

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #3333:
URL: https://github.com/apache/incubator-kyuubi/pull/3333#discussion_r954586718


##########
extensions/spark/kyuubi-spark-authz/src/test/resources/log4j2-test.xml:
##########
@@ -39,5 +39,9 @@
             <AppenderRef ref="stdout"/>
             <AppenderRef ref="file"/>
         </Root>
+        <!-- Note: The log level of org.apache.ranger cannot be `DEBUG` currently. otherwise, NPE will been thrown -->
+        <Logger name="org.apache.ranger" level="warn" additivity="false">

Review Comment:
   ok, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3333: [KYUUBI #3217][FOLLOWUP] Bump ranger version to 2.3.0

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3333:
URL: https://github.com/apache/incubator-kyuubi/pull/3333#discussion_r954565935


##########
extensions/spark/kyuubi-spark-authz/src/test/resources/log4j2-test.xml:
##########
@@ -39,5 +39,9 @@
             <AppenderRef ref="stdout"/>
             <AppenderRef ref="file"/>
         </Root>
+        <!-- Note: The log level of org.apache.ranger cannot be `DEBUG` currently. otherwise, NPE will been thrown -->

Review Comment:
   Mention the JIRA issue ticket here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3333: [KYUUBI #3217][FOLLOWUP] Bump ranger version to 2.3.0

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3333:
URL: https://github.com/apache/incubator-kyuubi/pull/3333#discussion_r954574298


##########
extensions/spark/kyuubi-spark-authz/src/test/resources/log4j2-test.xml:
##########
@@ -39,5 +39,9 @@
             <AppenderRef ref="stdout"/>
             <AppenderRef ref="file"/>
         </Root>
+        <!-- Note: The log level of org.apache.ranger cannot be `DEBUG` currently. otherwise, NPE will been thrown -->
+        <Logger name="org.apache.ranger" level="warn" additivity="false">
+            <AppenderRef ref="Console" />

Review Comment:
   ```suggestion
               <AppenderRef ref="stdout"/>
               <AppenderRef ref="file"/>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3333: [KYUUBI #3217][FOLLOWUP] Bump ranger version to 2.3.0

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3333:
URL: https://github.com/apache/incubator-kyuubi/pull/3333#discussion_r954575286


##########
extensions/spark/kyuubi-spark-authz/src/test/resources/log4j2-test.xml:
##########
@@ -39,5 +39,9 @@
             <AppenderRef ref="stdout"/>
             <AppenderRef ref="file"/>
         </Root>
+        <!-- Note: The log level of org.apache.ranger cannot be `DEBUG` currently. otherwise, NPE will been thrown -->
+        <Logger name="org.apache.ranger" level="warn" additivity="false">

Review Comment:
   and can we configure the special Logger instead of the whole package?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3333: [KYUUBI #3217][FOLLOWUP] Bump ranger version to 2.3.0

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3333:
URL: https://github.com/apache/incubator-kyuubi/pull/3333#discussion_r954574592


##########
extensions/spark/kyuubi-spark-authz/src/test/resources/log4j2-test.xml:
##########
@@ -39,5 +39,9 @@
             <AppenderRef ref="stdout"/>
             <AppenderRef ref="file"/>
         </Root>
+        <!-- Note: The log level of org.apache.ranger cannot be `DEBUG` currently. otherwise, NPE will been thrown -->
+        <Logger name="org.apache.ranger" level="warn" additivity="false">

Review Comment:
   UPPERCASE WARN



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] pan3793 closed pull request #3333: Bump ranger version from 2.2.0 to 2.3.0

Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3333: Bump ranger version from 2.2.0 to 2.3.0
URL: https://github.com/apache/incubator-kyuubi/pull/3333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org