You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/05 23:13:49 UTC
[GitHub] [ozone] smengcl opened a new pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
smengcl opened a new pull request #2713:
URL: https://github.com/apache/ozone/pull/2713
## What changes were proposed in this pull request?
Right now the output is just a bunch of separate JSONs (not a valid one as a whole).
This patch improves it by grouping them into one JSON array. This should make it easier to be parsed by `jq` and other utilies.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5824
## How was this patch tested?
- [x] Added integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#issuecomment-938029696
Thanks @swagle @ayushtkn @adoroszlai @errose28 for the +1s. I have merged the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#issuecomment-937303991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl merged pull request #2713:
URL: https://github.com/apache/ozone/pull/2713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#issuecomment-936495664
Thanks @smengcl for updating the patch. There is one more test failure in `TestOzoneShellHA.testOzoneShCmdList(TestOzoneShellHA.java:444)`, which expects no output, but gets `"[ ]\n"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r723002688
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java
##########
@@ -855,4 +861,36 @@ public void testShQuota() throws Exception {
objectStore.getVolume("vol4").deleteBucket("buck4");
objectStore.deleteVolume("vol4");
}
+
+ @Test
+ public void testListVolumeShouldPrintValidJson()
+ throws UnsupportedEncodingException {
+
+ final List<String> volumesForThisTest =
+ Arrays.asList("random-vol1", "random-vol2", "random-vol3");
+
+ // Create test volumes
+ volumesForThisTest.forEach(vol ->
+ execute(ozoneShell, new String[] {"volume", "create", vol}));
+ out.reset();
+
+ execute(ozoneShell, new String[] {"volume", "list"});
+
+ // Expect proper JSON output
+ final ArrayList<LinkedTreeMap<String, String>> outArray =
+ new Gson().fromJson(out.toString(DEFAULT_ENCODING), ArrayList.class);
+ // Might have s3v and volumes from other test cases that aren't clean up.
+ Assert.assertTrue(outArray.size() >= 3);
+ final HashSet<String> volumesSet = new HashSet<>(volumesForThisTest);
+ outArray.forEach(treeMap -> volumesSet.remove(treeMap.get("name")));
+
+ // Should have found all 3 volumes we created for this test
+ Assert.assertEquals(0, volumesSet.size());
+
+ // Clean up
+ volumesForThisTest.forEach(vol ->
+ execute(ozoneShell, new String[] {"volume", "delete", vol}));
+ out.reset();
+ err.reset();
Review comment:
Good point. Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r722998615
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/ListVolumeHandler.java
##########
@@ -85,11 +85,18 @@ protected void execute(OzoneClient client, OzoneAddress address)
}
int counter = 0;
+ final StringBuilder res = new StringBuilder("[ "); // Mark JSON array start
Review comment:
yeah surely I can just print that to stdout.. i imagine this can only OOM the client if we are returning 100000s of volumes.
`StringBuilder` IMO is just a cleaner implementation here. No need to deal with `print()` then `println()` for the array element delimiter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r723612131
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/Handler.java
##########
@@ -118,6 +119,29 @@ protected void printObjectAsJson(Object o) throws IOException {
out().println(JsonUtils.toJsonStringWithDefaultPrettyPrinter(o));
}
+ protected String objectToJsonString(Object o) throws IOException {
+ return JsonUtils.toJsonStringWithDefaultPrettyPrinter(o);
+ }
+
+ /**
+ * Print the results in the iterator as a valid JSON array to out().
+ * @return Number of entries actually printed.
+ */
+ protected int printAsJsonArray(Iterator<?> iterator, int limit)
+ throws IOException {
+ int counter = 0;
+ out().print("[ ");
+ while (limit > counter && iterator.hasNext()) {
+ if (counter > 0) {
+ out().print(", ");
+ }
+ out().print(objectToJsonString(iterator.next()));
+ counter++;
+ }
+ out().println(" ]");
Review comment:
Yup. Great idea. I should have done this in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r722963383
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java
##########
@@ -22,10 +22,14 @@
import java.io.FileNotFoundException;
import java.io.PrintStream;
import java.io.UnsupportedEncodingException;
+import java.util.ArrayList;
import java.util.Arrays;
+import java.util.HashSet;
import java.util.List;
import java.util.UUID;
+import com.google.gson.Gson;
+import com.google.gson.internal.LinkedTreeMap;
Review comment:
The import order is wrong should be in the below block with ```import com.google.common.base.Strings```
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java
##########
@@ -855,4 +861,36 @@ public void testShQuota() throws Exception {
objectStore.getVolume("vol4").deleteBucket("buck4");
objectStore.deleteVolume("vol4");
}
+
+ @Test
+ public void testListVolumeShouldPrintValidJson()
+ throws UnsupportedEncodingException {
+
+ final List<String> volumesForThisTest =
+ Arrays.asList("random-vol1", "random-vol2", "random-vol3");
+
+ // Create test volumes
+ volumesForThisTest.forEach(vol ->
+ execute(ozoneShell, new String[] {"volume", "create", vol}));
+ out.reset();
+
+ execute(ozoneShell, new String[] {"volume", "list"});
+
+ // Expect proper JSON output
+ final ArrayList<LinkedTreeMap<String, String>> outArray =
+ new Gson().fromJson(out.toString(DEFAULT_ENCODING), ArrayList.class);
Review comment:
Out of curiosity why ``toString(DEFAULT_ENCODING)`` isn't it already set to UTF_8 in the before?
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java
##########
@@ -855,4 +861,36 @@ public void testShQuota() throws Exception {
objectStore.getVolume("vol4").deleteBucket("buck4");
objectStore.deleteVolume("vol4");
}
+
+ @Test
+ public void testListVolumeShouldPrintValidJson()
+ throws UnsupportedEncodingException {
+
+ final List<String> volumesForThisTest =
+ Arrays.asList("random-vol1", "random-vol2", "random-vol3");
+
+ // Create test volumes
+ volumesForThisTest.forEach(vol ->
+ execute(ozoneShell, new String[] {"volume", "create", vol}));
+ out.reset();
+
+ execute(ozoneShell, new String[] {"volume", "list"});
+
+ // Expect proper JSON output
+ final ArrayList<LinkedTreeMap<String, String>> outArray =
+ new Gson().fromJson(out.toString(DEFAULT_ENCODING), ArrayList.class);
+ // Might have s3v and volumes from other test cases that aren't clean up.
+ Assert.assertTrue(outArray.size() >= 3);
+ final HashSet<String> volumesSet = new HashSet<>(volumesForThisTest);
+ outArray.forEach(treeMap -> volumesSet.remove(treeMap.get("name")));
+
+ // Should have found all 3 volumes we created for this test
+ Assert.assertEquals(0, volumesSet.size());
+
+ // Clean up
+ volumesForThisTest.forEach(vol ->
+ execute(ozoneShell, new String[] {"volume", "delete", vol}));
+ out.reset();
+ err.reset();
Review comment:
This seems redundant? The After block does this reset?
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/ListVolumeHandler.java
##########
@@ -85,11 +85,18 @@ protected void execute(OzoneClient client, OzoneAddress address)
}
int counter = 0;
+ final StringBuilder res = new StringBuilder("[ "); // Mark JSON array start
Review comment:
Quick Question:
Why you can't use the `out` itself? Why you are moving to `StringBuilder`? Earlier the flow was we are just producing json and pushing it to the out stream, now If I catch correct we will be storing it till the end and then push, Any reasons for doing so? Does this approach not increase the memory pressure, storing the entire list till end? Or did I interpret it wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#issuecomment-935761493
> Thanks @smengcl for the improvement.
>
> Acceptance test failure is due to the output change (it already uses `jq` to verify output).
>
> https://github.com/apache/ozone/blob/20e8429a86c4cf7bf0d960f3197e936f64be667c/hadoop-ozone/dist/src/main/smoketest/basic/ozone-shell-lib.robot#L37
>
> Should we mention this change in release notes (it might break scripts as our tests)?
Done. Good point. I should add a release note on the jira.
Also I feel like I should do this to `bucket list` and `key list` as well, if that's not the case already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on a change in pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
errose28 commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r723505476
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/Handler.java
##########
@@ -118,6 +119,29 @@ protected void printObjectAsJson(Object o) throws IOException {
out().println(JsonUtils.toJsonStringWithDefaultPrettyPrinter(o));
}
+ protected String objectToJsonString(Object o) throws IOException {
+ return JsonUtils.toJsonStringWithDefaultPrettyPrinter(o);
+ }
+
+ /**
+ * Print the results in the iterator as a valid JSON array to out().
+ * @return Number of entries actually printed.
+ */
+ protected int printAsJsonArray(Iterator<?> iterator, int limit)
+ throws IOException {
+ int counter = 0;
+ out().print("[ ");
+ while (limit > counter && iterator.hasNext()) {
+ if (counter > 0) {
+ out().print(", ");
+ }
+ out().print(objectToJsonString(iterator.next()));
+ counter++;
+ }
+ out().println(" ]");
Review comment:
Can we build the list using jackson in `JsonUtils` instead of mixing library generated json with manually generated json? JsonUtil has a `toJsonList` function but its actually a deserializer, not a serializer as the name implies. It also looks unused. Maybe we can make to `toJsonList` actually serialize a list of objects and use that here instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r722996549
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java
##########
@@ -855,4 +861,36 @@ public void testShQuota() throws Exception {
objectStore.getVolume("vol4").deleteBucket("buck4");
objectStore.deleteVolume("vol4");
}
+
+ @Test
+ public void testListVolumeShouldPrintValidJson()
+ throws UnsupportedEncodingException {
+
+ final List<String> volumesForThisTest =
+ Arrays.asList("random-vol1", "random-vol2", "random-vol3");
+
+ // Create test volumes
+ volumesForThisTest.forEach(vol ->
+ execute(ozoneShell, new String[] {"volume", "create", vol}));
+ out.reset();
+
+ execute(ozoneShell, new String[] {"volume", "list"});
+
+ // Expect proper JSON output
+ final ArrayList<LinkedTreeMap<String, String>> outArray =
+ new Gson().fromJson(out.toString(DEFAULT_ENCODING), ArrayList.class);
Review comment:
Unfortunately `findbugs` complains if I omit the `UTF_8` encoding.
```
H I Dm: Found reliance on default encoding in org.apache.hadoop.ozone.shell.TestOzoneShellHA.testListVolumeShouldOutputValidJson(): java.io.ByteArrayOutputStream.toString() At TestOzoneShellHA.java:[line 878]
```
https://github.com/apache/ozone/runs/3809056152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r722996549
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneShellHA.java
##########
@@ -855,4 +861,36 @@ public void testShQuota() throws Exception {
objectStore.getVolume("vol4").deleteBucket("buck4");
objectStore.deleteVolume("vol4");
}
+
+ @Test
+ public void testListVolumeShouldPrintValidJson()
+ throws UnsupportedEncodingException {
+
+ final List<String> volumesForThisTest =
+ Arrays.asList("random-vol1", "random-vol2", "random-vol3");
+
+ // Create test volumes
+ volumesForThisTest.forEach(vol ->
+ execute(ozoneShell, new String[] {"volume", "create", vol}));
+ out.reset();
+
+ execute(ozoneShell, new String[] {"volume", "list"});
+
+ // Expect proper JSON output
+ final ArrayList<LinkedTreeMap<String, String>> outArray =
+ new Gson().fromJson(out.toString(DEFAULT_ENCODING), ArrayList.class);
Review comment:
No. The `findbugs` complains if I omit the `UTF_8` encoding.
```
H I Dm: Found reliance on default encoding in org.apache.hadoop.ozone.shell.TestOzoneShellHA.testListVolumeShouldOutputValidJson(): java.io.ByteArrayOutputStream.toString() At TestOzoneShellHA.java:[line 878]
```
https://github.com/apache/ozone/runs/3809056152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r722998615
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/ListVolumeHandler.java
##########
@@ -85,11 +85,18 @@ protected void execute(OzoneClient client, OzoneAddress address)
}
int counter = 0;
+ final StringBuilder res = new StringBuilder("[ "); // Mark JSON array start
Review comment:
yeah surely I can just print that to stdout.. i imagine this can only OOM the client if we are returning 100000s of volumes.
`StringBuilder` IMO is just a cleaner implementation here. No need to deal with `print()` then `println()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on a change in pull request #2713: HDDS-5824. `ozone sh volume list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#discussion_r723016365
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/ListVolumeHandler.java
##########
@@ -85,11 +85,18 @@ protected void execute(OzoneClient client, OzoneAddress address)
}
int counter = 0;
+ final StringBuilder res = new StringBuilder("[ "); // Mark JSON array start
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl merged pull request #2713:
URL: https://github.com/apache/ozone/pull/2713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #2713: HDDS-5824. `ozone sh volume/bucket/key list` should print valid JSON array
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #2713:
URL: https://github.com/apache/ozone/pull/2713#issuecomment-937303991
Thanks @swagle @ayushtkn @adoroszlai @errose28 for reviewing.
All comments addressed. CI is green. Pls take another look. Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org